Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions
Date	2015-11-22 21:40 +0100
Message-ID	<qxJAt-mn-3@gated-at.bofh.it> (permalink)
References	<qxj3j-7GJ-3@gated-at.bofh.it> <qxj3l-7GJ-33@gated-at.bofh.it> <qxJAt-mn-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Nov 22, 2015 at 09:31:28PM +0100, Pablo Neira Ayuso wrote:
> On Sat, Nov 21, 2015 at 11:18:46AM -0500, Tejun Heo wrote:
> > --- a/extensions/libxt_cgroup.c
> > +++ b/extensions/libxt_cgroup.c
> > @@ -3,30 +3,30 @@
> >  #include <linux/netfilter/xt_cgroup.h>
> >  
> >  enum {
> > -	O_CGROUP = 0,
> > +	O_CLASSID = 0,
> >  };
> >  
> > -static void cgroup_help(void)
> > +static void cgroup_help_v0(void)
> >  {
> >  	printf(
> >  "cgroup match options:\n"
> > -"[!] --cgroup fwid  Match cgroup fwid\n");
> > +"[!] --cgroup classid            Match cgroup classid\n");
> 
> We have to keep the old cgroup integer ID around for a while,
> otherwise we'll break users with old kernels and new iptables
> utilities.

Oh, I see.

This is just a rename to prepare the string based identifier.

Sorry for the noise.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in xt_cgroup Tejun Heo <tj@kernel.org> - 2015-11-21 17:20 +0100
  [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Tejun Heo <tj@kernel.org> - 2015-11-21 17:20 +0100
    Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso <pablo@netfilter.org> - 2015-11-22 21:40 +0100
    Re: [PATCH 1/2 iptables] libxt_cgroup: prepare for multi revisions Pablo Neira Ayuso <pablo@netfilter.org> - 2015-11-22 21:40 +0100
  Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 08:20 +0100
    Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 10:00 +0100
      Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Tejun Heo <tj@kernel.org> - 2015-11-23 17:00 +0100
        Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Daniel Wagner <daniel.wagner@bmw-carit.de> - 2015-11-23 17:00 +0100
        Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Tejun Heo <tj@kernel.org> - 2015-11-23 21:00 +0100
  Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match  in xt_cgroup David Miller <davem@davemloft.net> - 2015-11-23 21:50 +0100
    Re: [PATCHSET v3] netfilter, cgroup: implement cgroup2 path match in  xt_cgroup Tejun Heo <tj@kernel.org> - 2015-11-23 22:00 +0100

csiph-web