Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274933

Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Fri, Nov 20, 2015 at 05:45:48PM +0100, Marcus Weseloh wrote:
> 2015-11-20 17:12 GMT+01:00 Rob Herring <robh@kernel.org>:
> > On Fri, Nov 20, 2015 at 02:56:34PM +0100, Marcus Weseloh wrote:
> >> > (and the wdelay should
> >> > arguably be a core-spi thing, not a sunxi thing, but that's a separate
> >> > discussion)
> >>
> >> I've been thinking about that, but it seemed to big a change to
> >> attempt with my limited kernel hacking experience.
> >
> > It is not any bigger. You just need to document it in the core binding.
> > It would still be read by the drivers using it.
> 
> Julien, Rob: thanks for your comments! Ok, I will make the following changes:
> 
> - remove "sun4i,spi-wdelay" from the sun4i binding and add the
> property to the spi-bus.txt binding instead
> - remove the comment about the additional 3 cycles from the documentation
> - modfy the spi-sun4i driver to take care of the minimum 3 cycle period
> 
> Does that sound right?
> 
> And maybe I could also use a more descriptive name for the property,
> maybe "spi-word-wait-cycles"?

I don't think it should be in a clock-rate dependant unit. Using micro
or nano-seconds would be more appropriate I guess.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] spi: dts: sun4i: Add support for inter-word wait cycles Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-19 17:00 +0100
  [PATCH] spi: dts: sun4i: Add support for inter-word wait cycles using the SPI Wait Clock Register Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-19 17:00 +0100
    Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Julian Calaby <julian.calaby@gmail.com> - 2015-11-20 00:00 +0100
      Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-20 09:50 +0100
        Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Julian Calaby <julian.calaby@gmail.com> - 2015-11-20 11:20 +0100
          Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-20 15:00 +0100
            Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for  inter-word wait cycles using the SPI Wait Clock Register Rob Herring <robh@kernel.org> - 2015-11-20 17:20 +0100
              Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-20 17:50 +0100
                Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for  inter-word wait cycles using the SPI Wait Clock Register Maxime Ripard <maxime.ripard@free-electrons.com> - 2015-11-22 20:50 +0100
                Re: [linux-sunxi] [PATCH] spi: dts: sun4i: Add support for inter-word  wait cycles using the SPI Wait Clock Register Marcus Weseloh <mweseloh42@gmail.com> - 2015-11-23 10:20 +0100
    Re: [PATCH] spi: dts: sun4i: Add support for inter-word wait cycles  using the SPI Wait Clock Register Rob Herring <robh@kernel.org> - 2015-11-20 17:10 +0100

csiph-web