Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274864

Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sat, Nov 21, 2015 at 02:40:50PM -0600, Andrew F. Davis wrote:
> On 11/21/2015 07:37 AM, Mark Brown wrote:

> >An earlier version of this patch has already been applied, please don't
> >resend already applied patches but send incremental patches with any
> >changes.

> Odd, I didn't seem to get any message for this getting applied. Looks
> like only a couple lines difference from the version in the regulators
> branch, I don't imagine you are able to rebase that with these changes?

As a matter of policy I try to avoid rewriting history unless it is
really required.

> Anyway the reason that line needed changed is over a confusion in
> what the 'of_node' does in 'struct regulator_config'. The description
> seems to make it seem like it is the node that gets checked for
> init data.

The current behaviour is the intended behaviour.

> >* @of_node: OpenFirmware node to parse for device tree bindings (may be
> >*           NULL).

> But the 'of_node' that is actually searched is the one given in
> regulator_config->dev->of_node. Is this intended behavior (drivers
> assume it is so it probably has to be now) and if so, the above
> description might need to be clarified as too what that 'of_node'
> pointer really does?

Please submit a patch with any clarification you think is needed.
of_node is the name of the container subnode of the main node for the
device where we look for init data - both are used.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/4] Add support for the TI TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-20 00:10 +0100
  [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-20 00:10 +0100
    Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC Mark Brown <broonie@kernel.org> - 2015-11-21 14:40 +0100
      Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-21 21:50 +0100
        Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC Mark Brown <broonie@kernel.org> - 2015-11-22 14:20 +0100
          Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-23 18:50 +0100
            Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC Mark Brown <broonie@kernel.org> - 2015-11-23 20:10 +0100
              Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-23 20:20 +0100
                Re: [PATCH v4 3/4] regulator: tps65086: Add regulator driver for the  TPS65086 PMIC Mark Brown <broonie@kernel.org> - 2015-11-24 13:20 +0100
  [PATCH v4 4/4] gpio: tps65086: Add GPO driver for the TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-20 00:10 +0100
    Re: [PATCH v4 4/4] gpio: tps65086: Add GPO driver for the TPS65086 PMIC Linus Walleij <linus.walleij@linaro.org> - 2015-11-30 10:00 +0100
  [PATCH v4 2/4] mfd: tps65086: Add driver for the TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-20 00:10 +0100
    Re: [PATCH v4 2/4] mfd: tps65086: Add driver for the TPS65086 PMIC Lee Jones <lee.jones@linaro.org> - 2015-11-23 17:30 +0100
  [PATCH v4 1/4] Documentation: tps65086: Add DT bindings for the TPS65086 PMIC "Andrew F. Davis" <afd@ti.com> - 2015-11-20 00:10 +0100
    Re: [PATCH v4 1/4] Documentation: tps65086: Add DT bindings for the  TPS65086 PMIC Rob Herring <robh@kernel.org> - 2015-11-20 17:40 +0100
    Re: [PATCH v4 1/4] Documentation: tps65086: Add DT bindings for the  TPS65086 PMIC Lee Jones <lee.jones@linaro.org> - 2015-11-23 17:10 +0100

csiph-web