Re: [PATCH] IB/iser: use sector_div instead of do_div

From	Sagi Grimberg <sagig@dev.mellanox.co.il>
Newsgroups	linux.kernel
Subject	Re: [PATCH] IB/iser: use sector_div instead of do_div
Date	2015-11-21 03:20 +0100
Message-ID	<qx5Wq-7lt-5@gated-at.bofh.it> (permalink)
References	<qwX2O-1hA-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> do_div is the wrong way to divide a sector_t, as it is less
> efficient when sector_t is 32-bit wide. With the upcoming
> do_div optimizations, the kernel starts warning about this:
>
> drivers/infiniband/ulp/iser/iser_verbs.c:1296:4: note: in expansion of macro 'do_div'
> include/asm-generic/div64.h:224:22: warning: passing argument 1 of '__div64_32' from incompatible pointer type
>
> This changes the code to use sector_div instead, which always
> produces optimal code.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd,

Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/iser: use sector_div instead of do_div Arnd Bergmann <arnd@arndb.de> - 2015-11-20 17:50 +0100
  Re: [PATCH] IB/iser: use sector_div instead of do_div Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-21 03:20 +0100

csiph-web