Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1273088

Re: [PATCH] clocksource: Store reg field within struct clocksource

Show all headers | View raw

On 19/11/2015 12:14, Thomas Gleixner wrote:

> So yes, the alignment of the clocksource struct is not longer
> relevant. The case where we access clocksource->max_cycles is when
> CONFIG_DEBUG_TIMEKEEPING is enabled, which imposes worse performance
> problems to timekeeping than the extra cacheline.
> 
> So the simple solution for this issue is indeed the one liner below.

It would make sense to also remove the comment emphasizing the
alignment requirement.

Regards.

8<-------------------

diff --git a/include/linux/clocksource.h b/include/linux/clocksource.h
index 278dd279a7a8..6a0f86a9a92d 100644
--- a/include/linux/clocksource.h
+++ b/include/linux/clocksource.h
@@ -64,10 +64,6 @@ struct module;
  * @owner:             module reference, must be set by clocksource in modules
  */
 struct clocksource {
-       /*
-        * Hotpath data, fits in a single cache line when the
-        * clocksource itself is cacheline aligned.
-        */
        cycle_t (*read)(struct clocksource *cs);
        cycle_t mask;
        u32 mult;
@@ -95,7 +91,7 @@ struct clocksource {
        cycle_t wd_last;
 #endif
        struct module *owner;
-} ____cacheline_aligned;
+};
 
 /*
  * Clock source flags bits::

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-18 14:50 +0100
  Re: [PATCH] clocksource: Store reg field within struct clocksource Måns Rullgård <mans@mansr.com> - 2015-11-18 15:00 +0100
  Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-18 18:30 +0100
    Re: [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-19 10:40 +0100
      Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-19 11:40 +0100
        Re: [PATCH] clocksource: Store reg field within struct clocksource Thomas Gleixner <tglx@linutronix.de> - 2015-11-19 11:40 +0100
          Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-19 11:50 +0100
    Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-19 11:40 +0100
      Re: [PATCH] clocksource: Store reg field within struct clocksource Thomas Gleixner <tglx@linutronix.de> - 2015-11-19 11:50 +0100
        Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-19 12:10 +0100
          Re: [PATCH] clocksource: Store reg field within struct clocksource Thomas Gleixner <tglx@linutronix.de> - 2015-11-19 12:20 +0100
            Re: [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-19 13:30 +0100
              Re: [PATCH] clocksource: Store reg field within struct clocksource Thomas Gleixner <tglx@linutronix.de> - 2015-11-19 15:00 +0100
                Re: [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-24 13:40 +0100
            [tip:timers/core] timekeeping:   Lift clocksource cacheline restriction tip-bot for Thomas Gleixner <tipbot@zytor.com> - 2015-11-25 22:40 +0100
      Re: [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-19 12:00 +0100
        Re: [PATCH] clocksource: Store reg field within struct clocksource Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-19 12:30 +0100
          Re: [PATCH] clocksource: Store reg field within struct clocksource Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-19 13:50 +0100
    Re: [PATCH] clocksource: Store reg field within struct clocksource Thomas Gleixner <tglx@linutronix.de> - 2015-11-19 11:40 +0100

csiph-web