Re: [PATCH] PCI: Fix logic OF logic in pci_dma_configure()

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PCI: Fix logic OF logic in pci_dma_configure()
Date	2015-11-19 09:30 +0100
Message-ID	<qwsLn-6Qc-1@gated-at.bofh.it> (permalink)
References	<qwlJT-2a0-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday 18 November 2015 16:49:52 Suravee Suthikulpanit wrote:
> -       if (IS_ENABLED(CONFIG_OF) && dev->dev.of_node) {
> -               if (bridge->parent)
> +       if (IS_ENABLED(CONFIG_OF) &&
> +               bridge->parent && bridge->parent->of_node) {
>                         of_dma_configure(&dev->dev, bridge->parent->of_node);
> 

Acked-by: Arnd Bergmann <arnd@arndb.de>

I was wondering for a bit whether we should warn about the case where there
is no of_node pointer, as that would mean we cannot do DMA on that PCI
device, but on second thought we have to do it exactly like you do, because
we would otherwise break machines that do not use DT.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] PCI: Fix logic OF logic in pci_dma_configure() Suravee Suthikulpanit <Suravee.Suthikulpanit@amd.com> - 2015-11-19 02:00 +0100
  Re: [PATCH] PCI: Fix logic OF logic in pci_dma_configure() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-19 02:30 +0100
  Re: [PATCH] PCI: Fix logic OF logic in pci_dma_configure() Arnd Bergmann <arnd@arndb.de> - 2015-11-19 09:30 +0100

csiph-web