Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1272921
| From | Ingo Molnar <mingo@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: i915.ko WC writes are slow after ea8596bb2d8d379 |
| Date | 2015-11-19 09:20 +0100 |
| Message-ID | <qwsBJ-6MQ-21@gated-at.bofh.it> (permalink) |
| References | <o8VpT-1dR-1@gated-at.bofh.it> <o8WvE-2R6-17@gated-at.bofh.it> <qwcng-4gQ-15@gated-at.bofh.it> <qwdjl-4US-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
* Andy Lutomirski <luto@amacapital.net> wrote: > On Wed, Nov 18, 2015 at 6:48 AM, Chris Wilson <chris@chris-wilson.co.uk> wrote: > > Although > > > > diff --git a/include/linux/stop_machine.h b/include/linux/stop_machine.h > > index d2abbdb..ff4f029 100644 > > --- a/include/linux/stop_machine.h > > +++ b/include/linux/stop_machine.h > > @@ -97,7 +97,7 @@ static inline int try_stop_cpus(const struct cpumask *cpumask, > > * grabbing every spinlock (and more). So the "read" side to such a > > * lock is anything which disables preemption. > > */ > > -#if defined(CONFIG_STOP_MACHINE) && defined(CONFIG_SMP) > > +#if defined(CONFIG_SMP) || defined(CONFIG_HOTPLUG_CPU) > > [...] > > This seems much better. Having a set of stop_machine functions around > that don't work depending on config seems dangerous. Agreed. Acked-by: Ingo Molnar <mingo@kernel.org> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: i915.ko WC writes are slow after ea8596bb2d8d379 Chris Wilson <chris@chris-wilson.co.uk> - 2015-11-18 16:00 +0100
Re: i915.ko WC writes are slow after ea8596bb2d8d379 Andy Lutomirski <luto@amacapital.net> - 2015-11-18 17:00 +0100
Re: i915.ko WC writes are slow after ea8596bb2d8d379 Ingo Molnar <mingo@kernel.org> - 2015-11-19 09:20 +0100
[PATCH] kernel: Remove stop_machine() Kconfig dependency Chris Wilson <chris@chris-wilson.co.uk> - 2015-11-19 11:10 +0100
Re: i915.ko WC writes are slow after ea8596bb2d8d379 Ingo Molnar <mingo@kernel.org> - 2015-11-19 09:20 +0100
csiph-web