[PATCH] drivers: power: set IRQF_ONESHOT if no primary handler is specified

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Saurabh Sengar <saurabh.truth@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drivers: power: set IRQF_ONESHOT if no primary handler is specified
Date	Thu, 19 Nov 2015 08:20:02 +0100
Message-ID	<qwrFE-6aF-5@gated-at.bofh.it> (permalink)
X-Original-To	sre@kernel.org, dbaryshkov@gmail.com, dwmw2@infradead.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=M03QuwFLp5TmNL5qGdbXpYIXMQNTUgJohOcZN8IUmBI=; b=FNNJyNoYWlqVH5EP6I/6BYyClJYcm5VXFjWLO7ystmnrFgR0gHniWHjbzJCJyqYTDs E7/nloSfq/p9BycoFx9lZfIIKKSCGLRn8yW7Q/f/gEXl/s5Y6yMAF6khI5ZH2TLPCmUX HCfwQzFa2axINtBp+t3yot2BCq3PIb4fzZc5m9OtBsmt162VtXywud6snQqP5ja0/KXY XAUq4wBBgFCOncKcTGRjv3fAdkevrwD1CXTYkiEBIgnseuzrEpE3Ebm4g7V4cHLc/xoK 8bdyaO6vqTomBlU5YA7L7oU3qvVhxwAZZJRhtL47XTrIaCDQM4dQv5egN+uL/7AurzXn XJqg==
X-Received	by 10.68.219.40 with SMTP id pl8mr8478588pbc.136.1447917188927; Wed, 18 Nov 2015 23:13:08 -0800 (PST)
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	67
Organization	linux.* mail to news gateway
X-Original-Cc	Saurabh Sengar <saurabh.truth@gmail.com>
X-Original-Date	Thu, 19 Nov 2015 12:42:59 +0530
X-Original-Message-ID	<1447917179-9333-1-git-send-email-saurabh.truth@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1272891

Show key headers only | View raw

If no primary handler is specified for threaded_irq then a
default one is assigned which always returns IRQ_WAKE_THREAD.
This handler requires the IRQF_ONESHOT, because the source of
interrupt is not disabled.

Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
 drivers/power/max8903_charger.c | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/drivers/power/max8903_charger.c b/drivers/power/max8903_charger.c
index 6d39d52..17876ca 100644
--- a/drivers/power/max8903_charger.c
+++ b/drivers/power/max8903_charger.c
@@ -291,10 +291,10 @@ static int max8903_probe(struct platform_device *pdev)
 
 	if (pdata->dc_valid) {
 		ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->dok),
-						NULL, max8903_dcin,
-						IRQF_TRIGGER_FALLING |
-						IRQF_TRIGGER_RISING,
-						"MAX8903 DC IN", data);
+					NULL, max8903_dcin,
+					IRQF_TRIGGER_FALLING |
+					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					"MAX8903 DC IN", data);
 		if (ret) {
 			dev_err(dev, "Cannot request irq %d for DC (%d)\n",
 					gpio_to_irq(pdata->dok), ret);
@@ -304,10 +304,10 @@ static int max8903_probe(struct platform_device *pdev)
 
 	if (pdata->usb_valid) {
 		ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->uok),
-						NULL, max8903_usbin,
-						IRQF_TRIGGER_FALLING |
-						IRQF_TRIGGER_RISING,
-						"MAX8903 USB IN", data);
+					NULL, max8903_usbin,
+					IRQF_TRIGGER_FALLING |
+					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					"MAX8903 USB IN", data);
 		if (ret) {
 			dev_err(dev, "Cannot request irq %d for USB (%d)\n",
 					gpio_to_irq(pdata->uok), ret);
@@ -317,10 +317,10 @@ static int max8903_probe(struct platform_device *pdev)
 
 	if (pdata->flt) {
 		ret = devm_request_threaded_irq(dev, gpio_to_irq(pdata->flt),
-						NULL, max8903_fault,
-						IRQF_TRIGGER_FALLING |
-						IRQF_TRIGGER_RISING,
-						"MAX8903 Fault", data);
+					NULL, max8903_fault,
+					IRQF_TRIGGER_FALLING |
+					IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+					"MAX8903 Fault", data);
 		if (ret) {
 			dev_err(dev, "Cannot request irq %d for Fault (%d)\n",
 					gpio_to_irq(pdata->flt), ret);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] drivers: power: set IRQF_ONESHOT if no primary handler is specified Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-19 08:20 +0100

csiph-web