Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT

Path	csiph.com!news.mixmin.net!weretis.net!feeder4.news.weretis.net!storethat.news.telefonica.de!telefonica.de!news.panservice.it!bofh.it!news.nic.it!robomod
From	Michael Schmitz <schmitzmic@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT
Date	Thu, 19 Nov 2015 05:50:01 +0100
Message-ID	<qwpkt-4yB-9@gated-at.bofh.it> (permalink)
References	<qw6Bc-vx-5@gated-at.bofh.it> <qw74e-WO-23@gated-at.bofh.it> <qwnLH-3EE-3@gated-at.bofh.it> <qwoHL-4kt-3@gated-at.bofh.it>
X-Original-To	Finn Thain <fthain@telegraphics.com.au>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=xlfA9rPpbzqLfUtyZm2IPuqiqWjMzXQE6P5PuTRDQag=; b=VpUaHIgsuUUp8PqWub9BkmmVbzE15fa7p4yB+NTqJ0BolTmAk35o+3ISZTp1KxXqlG quDQtDZwIzCMoNB276z8NnhejcmI3jBvjHEjqehZmO6g4bRsETphBzVU+heseJe6O5Aq kqqR11bT7bLSQeeBXCahHZxP29gwGhEyfEZl6Q7A5u55JIi1qmROZscCcd+1r3hKaYxn 9qS1tMPzOlEiiyTuXZDOTU/ErMuMRiz/59E83siGbC1ZYLRBFvjwDe8DqCYRnU4x8OLj xU6bg2vHLsQ1Dq0qoIqie+dgvNjui2GT5MzTZ8mNrHP5e7UQBDU1CK9mO6v3svEZA5on 7iDg==
X-Received	by 10.68.91.228 with SMTP id ch4mr7636691pbb.41.1447908245338; Wed, 18 Nov 2015 20:44:05 -0800 (PST)
User-Agent	Mozilla/5.0 (X11; Linux ppc; rv:31.0) Gecko/20100101 Icedove/31.8.0
MIME-Version	1.0
Content-Type	text/plain; charset=windows-1252
Content-Transfer-Encoding	8bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	"James E.J. Bottomley" <JBottomley@odin.com>, linux-m68k@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Thu, 19 Nov 2015 17:43:57 +1300
X-Original-Message-ID	<564D538D.2070905@gmail.com>
X-Original-References	<20151118083455.331768508@telegraphics.com.au> <20151118083457.891774987@telegraphics.com.au> <564D3C6C.7020600@gmail.com> <alpine.LNX.2.00.1511191505080.13423@nippy.intranet>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1272849

Show key headers only | View raw

Hi Finn,

Am 19.11.2015 um 17:05 schrieb Finn Thain:
> w
> On Thu, 19 Nov 2015, Michael Schmitz wrote:
> 
>> Hi Finn,
>>
>> Am 18.11.2015 um 21:35 schrieb Finn Thain:
>>
>>> The bus reset may raise an interrupt. That would be new behaviour for 
>>> atari_scsi only when CONFIG_ATARI_SCSI_RESET_BOOT=n. The ST DMA 
>>> interrupt is not assigned to atari_scsi at this stage, so 
>>> CONFIG_ATARI_SCSI_RESET_BOOT=y may well be problematic already.
>>
>> I can confirm that the bus reset at boot has never been problematic in 
>> the past. It's been enabled in my kernels as long as I've used the 
>> driver (must be getting close to 20 years now).
> 
> That's good to know. I'm not sure why it was configurable in the first 
> place (long delays?). The new algorithm (the one I copied from NCR5380.c) 

The longer delays (and possibly a reset at boot) were only necessary for
certain CD-ROM drives. I don't think I have ever seen such a device, and
it's a bit unlikely any of these still survive. Reset at boot before
proper driver init can probably go away now.

> does not allow the user to prevent a possible scsi bus reset at driver 
> init time. The scsi bus reset only takes place if the driver discovers 
> that the bus was already wedged when it started. (It proved useful when I 
> was introducing faults for EH testing, BTW.)

Much saner approach, I'm sure. Don't forget the driver was written
before sophisticated error handling came along. Reset at boot and keep
your fingers crossed was the strategy in these days.

Cheers,

	Michael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT Finn Thain <fthain@telegraphics.com.au> - 2015-11-18 10:20 +0100
  Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY  and CONFIG_ATARI_SCSI_RESET_BOOT Michael Schmitz <schmitzmic@gmail.com> - 2015-11-19 04:10 +0100
    Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT,  CONFIG_ATARI_SCSI_TOSHIBA_DELAY and CONFIG_ATARI_SCSI_RESET_BOOT Finn Thain <fthain@telegraphics.com.au> - 2015-11-19 05:10 +0100
      Re: [PATCH 10/71] atari_NCR5380: Remove RESET_BOOT, CONFIG_ATARI_SCSI_TOSHIBA_DELAY  and CONFIG_ATARI_SCSI_RESET_BOOT Michael Schmitz <schmitzmic@gmail.com> - 2015-11-19 05:50 +0100

csiph-web