Re: Anonymous inode cleanup?

From	Rajat Jain <rajatxjain@gmail.com>
Newsgroups	linux.kernel
Subject	Re: Anonymous inode cleanup?
Date	2015-11-18 22:20 +0100
Message-ID	<qwij0-7N-7@gated-at.bofh.it> (permalink)
References	<qufpg-2lu-3@gated-at.bofh.it> <qugbE-2S1-5@gated-at.bofh.it> <qwhwC-7V2-15@gated-at.bofh.it> <qwi9j-8vZ-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

I see reference taken for the path and module in anon_inode_getfile()

Don't I need to drop that, or would fput() do it for me?

        path_put(&path);
        module_put(fops->owner);

On Wed, Nov 18, 2015 at 1:06 PM, Al Viro <viro@zeniv.linux.org.uk> wrote:
> On Wed, Nov 18, 2015 at 12:28:38PM -0800, Rajat Jain wrote:
>
>> > _If_ you are returning them via a sucky API, the right sequence is
>> >         reserve the descriptor(s)
>> >         set the file(s) up
>> >         fill whatever structure you'll be using to report descriptors to
>> > userland and copy it to userland memory
>>
>> If this step fails, what is the cleanup needed for "set the files up"
>> anon_inode_getfile() step? is it fput()?
>
> Yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: Anonymous inode cleanup? Rajat Jain <rajatxjain@gmail.com> - 2015-11-18 21:30 +0100
  Re: Anonymous inode cleanup? Al Viro <viro@ZenIV.linux.org.uk> - 2015-11-18 22:10 +0100
    Re: Anonymous inode cleanup? Rajat Jain <rajatxjain@gmail.com> - 2015-11-18 22:20 +0100
      Re: Anonymous inode cleanup? Al Viro <viro@ZenIV.linux.org.uk> - 2015-11-18 22:30 +0100
        Re: Anonymous inode cleanup? Rajat Jain <rajatxjain@gmail.com> - 2015-11-18 22:30 +0100

csiph-web