Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272609

[PATCH 3/3] vfs: show_vfsstat: remove redundant initialization and check of error code

Show all headers | View raw

As err variable is now always checked right after each assignment, its
initialization is redundant and could be safely removed.  For the same
reason, the last check of err is also redundant and could be removed as
well.

Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
---
 fs/proc_namespace.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fs/proc_namespace.c b/fs/proc_namespace.c
index 7a6b2f3..3f1190d 100644
--- a/fs/proc_namespace.c
+++ b/fs/proc_namespace.c
@@ -193,7 +193,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
 	struct mount *r = real_mount(mnt);
 	struct path mnt_path = { .dentry = mnt->mnt_root, .mnt = mnt };
 	struct super_block *sb = mnt_path.dentry->d_sb;
-	int err = 0;
+	int err;
 
 	/* device */
 	if (sb->s_op->show_devname) {
@@ -224,8 +224,7 @@ static int show_vfsstat(struct seq_file *m, struct vfsmount *mnt)
 	/* optional statistics */
 	if (sb->s_op->show_stats) {
 		seq_putc(m, ' ');
-		if (!err)
-			err = sb->s_op->show_stats(m, mnt_path.dentry);
+		err = sb->s_op->show_stats(m, mnt_path.dentry);
 	}
 
 	seq_putc(m, '\n');

-- 
ldv
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] vfs: show_vfsstat: do not ignore errors from show_devname method "Dmitry V. Levin" <ldv@altlinux.org> - 2015-11-18 19:00 +0100
  Re: [RESEND PATCH] vfs: show_vfsstat: do not ignore errors from  show_devname method Mateusz Guzik <mguzik@redhat.com> - 2015-11-18 19:10 +0100
    [PATCH 3/3] vfs: show_vfsstat: remove redundant initialization and check of error code "Dmitry V. Levin" <ldv@altlinux.org> - 2015-11-18 23:00 +0100
    [PATCH 1/3] vfs: show_vfsmnt: remove redundant initialization of error code "Dmitry V. Levin" <ldv@altlinux.org> - 2015-11-18 23:00 +0100
    [PATCH 2/3] vfs: show_mountinfo: cleanup error code checks "Dmitry V. Levin" <ldv@altlinux.org> - 2015-11-18 23:00 +0100

csiph-web