Re: [PATCH] writeback: initialize m_dirty to avoid compile warning

From	"Shi, Yang" <yang.shi@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] writeback: initialize m_dirty to avoid compile warning
Date	2015-11-18 19:40 +0100
Message-ID	<qwfOb-6FW-31@gated-at.bofh.it> (permalink)
References	<qurA7-1CA-41@gated-at.bofh.it> <qvY0W-3hg-11@gated-at.bofh.it> <qwfuO-6xU-3@gated-at.bofh.it> <qwfEv-6Cj-19@gated-at.bofh.it> <qwfOb-6FW-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/18/2015 10:33 AM, Tejun Heo wrote:
> Hello,
>
> On Wed, Nov 18, 2015 at 10:27:32AM -0800, Shi, Yang wrote:
>>> This was the main reason the code was structured the way it is.  If
>>> cgroup writeback is not enabled, any derefs of mdtc variables should
>>> trigger warnings.  Ugh... I don't know.  Compiler really should be
>>> able to tell this much.
>>
>> Thanks for the explanation. It sounds like a compiler problem.
>>
>> If you think it is still good to cease the compile warning, maybe we could
>
> If this is gonna be a problem with new gcc versions, I don't think we
> have any other options. :(
>
>> just assign it to an insane value as what Andrew suggested, maybe
>> 0xdeadbeef.
>
> I'd just keep it at zero.  Whatever we do, the effect is gonna be
> difficult to track down - it's not gonna blow up in an obvious way.
> Can you please add a comment tho explaining that this is to work
> around compiler deficiency?

Sure.

Other than this, in v2, I will just initialize m_dirty since compiler 
just reports it is uninitialized.

Thanks,
Yang

>
> Thanks.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] writeback: initialize m_dirty to avoid compile warning Andrew Morton <akpm@linux-foundation.org> - 2015-11-18 00:40 +0100
  Re: [PATCH] writeback: initialize m_dirty to avoid compile warning Arnd Bergmann <arnd@arndb.de> - 2015-11-18 11:00 +0100
    Re: [PATCH] writeback: initialize m_dirty to avoid compile warning "Shi, Yang" <yang.shi@linaro.org> - 2015-11-18 18:40 +0100
  Re: [PATCH] writeback: initialize m_dirty to avoid compile warning Tejun Heo <tj@kernel.org> - 2015-11-18 19:20 +0100
    Re: [PATCH] writeback: initialize m_dirty to avoid compile warning "Shi, Yang" <yang.shi@linaro.org> - 2015-11-18 19:30 +0100
      Re: [PATCH] writeback: initialize m_dirty to avoid compile warning Tejun Heo <tj@kernel.org> - 2015-11-18 19:40 +0100
        Re: [PATCH] writeback: initialize m_dirty to avoid compile warning "Shi, Yang" <yang.shi@linaro.org> - 2015-11-18 19:40 +0100
          Re: [PATCH] writeback: initialize m_dirty to avoid compile warning Andrew Morton <akpm@linux-foundation.org> - 2015-11-18 20:00 +0100
            Re: [PATCH] writeback: initialize m_dirty to avoid compile warning "Shi, Yang" <yang.shi@linaro.org> - 2015-11-18 20:00 +0100

csiph-web