Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1272382

Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc

Show all headers | View raw

On Wed 2015-11-18 10:39:24, Chris J Arges wrote:
> On 11/18/2015 10:37 AM, Petr Mladek wrote:
> > On Mon 2015-11-16 11:03:06, Chris J Arges wrote:
> >> In cases of duplicate symbols, sympos will be used to disambiguate instead
> >> of val. By default sympos will be 0, and patching will only succeed if
> >> the symbol is unique. Specifying a positive value will ensure that
> >> occurrence of the symbol in kallsyms for the patched object will be used
> >> for patching if it is valid.
> >>
> >> Remove klp_verify_callback, klp_verify_args and klp_verify_vmlinux_symbol
> >> as they are no longer used.
> >>
> >> >From the klp_reloc structure remove val, as it can be refactored as a
> >   ^
> > Please, remove this extra '>'. I guess that you cut&pasted the
> > comment from a mail reply ;-)
> > 
> > Best Regards,
> > Petr
> > 
> 
> I think that '>' was added in a subsequent reply. My patch doesn't have
> that, and I'm guessing checkpatch would have warned me about that as well.
> : )

Heh, it seems that some mail delivery tool or mail client tries to be
clever.  I see the '>' in you original mail. But it is fine in the
archive, see
http://article.gmane.org/gmane.linux.kernel/2086364
http://marc.info/?l=linux-kernel&m=144769343212421

I am sorry for the noise.

Best Regards,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/3 v7] livepatch: add sympos as disambiguator field to klp_reloc Chris J Arges <chris.j.arges@canonical.com> - 2015-11-16 18:10 +0100
  Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Miroslav Benes <mbenes@suse.cz> - 2015-11-18 11:00 +0100
    Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Josh Poimboeuf <jpoimboe@redhat.com> - 2015-11-18 15:10 +0100
      Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Petr Mladek <pmladek@suse.com> - 2015-11-18 17:50 +0100
  Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Petr Mladek <pmladek@suse.com> - 2015-11-18 17:40 +0100
    Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Chris J Arges <chris.j.arges@canonical.com> - 2015-11-18 17:40 +0100
      Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Petr Mladek <pmladek@suse.com> - 2015-11-18 18:00 +0100
        Re: [PATCH 2/3 v7] livepatch: add sympos as disambiguator field to  klp_reloc Jiri Kosina <jikos@kernel.org> - 2015-11-18 21:40 +0100

csiph-web