Re: [PATCH v2] pstore-ram: add Device Tree bindings

From	Greg Hackmann <ghackmann@google.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] pstore-ram: add Device Tree bindings
Date	2015-11-20 19:40 +0100
Message-ID	<qwYLf-2tX-1@gated-at.bofh.it> (permalink)
References	<qvCa6-5Wu-5@gated-at.bofh.it> <qvVPt-1Xk-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/17/2015 01:17 PM, Rob Herring wrote:
>> +- record-size: maximum size in bytes of each dump done on oops/panic
>> +  (defaults to 0)
>
> Perhaps the default should be something useful.

It's kind of a weird default, but I don't have any ideas for a better one.

First, the size you want is really determined by the number of dumps you 
want to keep in your circular buffer. That's not something I want to 
guess at.

Second, at least IME, a lot of devices legitimately want this set to 0. 
They're pulling in ramoops for the persistent kernel and userspace logs.

>> +- unbuffered: if present, use uncached mappings to map the reserved region
>> +  (defaults to cached mappings)
>
> It defaults to write-combined or buffered which is not really cached.

Will fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] pstore-ram: add Device Tree bindings Greg Hackmann <ghackmann@google.com> - 2015-11-17 01:20 +0100
  Re: [PATCH v2] pstore-ram: add Device Tree bindings Kees Cook <keescook@chromium.org> - 2015-11-17 18:50 +0100
  Re: [PATCH v2] pstore-ram: add Device Tree bindings Rob Herring <robh@kernel.org> - 2015-11-17 22:20 +0100
    Re: [PATCH v2] pstore-ram: add Device Tree bindings Greg Hackmann <ghackmann@google.com> - 2015-11-20 19:40 +0100

csiph-web