Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1274126

Re: [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a

From Rob Herring <robh@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a
Date 2015-11-20 15:50 +0100
Message-ID <qwVaG-8uf-7@gated-at.bofh.it> (permalink)
References <qwQNI-5O7-5@gated-at.bofh.it> <qwQXo-5SQ-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Nov 20, 2015 at 11:09:16AM +0100, Raphael Poggi wrote:
> From: Raphael Poggi <poggi.raph@gmail.com>
> 
> Add a binding for specify channel selection.
> 
> Signed-off-by: Raphael Poggi <poggi.raph@gmail.com>
> ---
>  Documentation/devicetree/bindings/sound/pcm1792a.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/pcm1792a.txt b/Documentation/devicetree/bindings/sound/pcm1792a.txt
> index 970ba1e..6e87a3a 100644
> --- a/Documentation/devicetree/bindings/sound/pcm1792a.txt
> +++ b/Documentation/devicetree/bindings/sound/pcm1792a.txt
> @@ -9,10 +9,15 @@ Required properties:
>  For required properties on SPI, please consult
>  Documentation/devicetree/bindings/spi/spi-bus.txt
>  
> +Optional properties:
> +- ti,side: specifie the channel side

typo

> +  insertion, removal.

why the line wrap?

I don't understand what this property is/does. Both the name and 
description are a bit terse.

> +
>  Examples:
>  
>  	codec_spi: 1792a@0 {
>  		compatible = "ti,pcm1792a";
>  		spi-max-frequency = <600000>;
> +		ti,side = <left>
                                ^
missing ;

>  	};
>  
> -- 
> 2.1.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/4] New feature and clean up for pcm1792a driver Raphael Poggi <poggi.raph@gmail.com> - 2015-11-20 11:10 +0100
  [PATCH 2/4] sound: codecs: pcm1792a: add define for register Raphael Poggi <poggi.raph@gmail.com> - 2015-11-20 11:10 +0100
    Re: [alsa-devel] [PATCH 2/4] sound: codecs: pcm1792a: add define for register Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-21 10:40 +0100
  [PATCH 1/4] sound: codecs: pcm1792a: clean function exit Raphael Poggi <poggi.raph@gmail.com> - 2015-11-20 11:20 +0100
    Re: [alsa-devel] [PATCH 1/4] sound: codecs: pcm1792a: clean function exit Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-21 10:40 +0100
      Re: [alsa-devel] [PATCH 1/4] sound: codecs: pcm1792a: clean function exit Raphaël Poggi <poggi.raph@gmail.com> - 2015-11-21 17:20 +0100
        Re: [alsa-devel] [PATCH 1/4] sound: codecs: pcm1792a: clean function  exit Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-21 17:40 +0100
  [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a Raphael Poggi <poggi.raph@gmail.com> - 2015-11-20 11:20 +0100
    Re: [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a Rob Herring <robh@kernel.org> - 2015-11-20 15:50 +0100
      Re: [alsa-devel] [PATCH 3/4] dt-bindings: sound: add binding for pcm1792a Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-20 16:10 +0100
  [PATCH 4/4] sound: codecs: pcm1792a: introduce channel side Raphael Poggi <poggi.raph@gmail.com> - 2015-11-20 11:20 +0100
    Re: [alsa-devel] [PATCH 4/4] sound: codecs: pcm1792a: introduce  channel side Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-21 10:40 +0100
      Re: [alsa-devel] [PATCH 4/4] sound: codecs: pcm1792a: introduce  channel side Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-24 09:30 +0100
        Re: [alsa-devel] [PATCH 4/4] sound: codecs: pcm1792a: introduce  channel side Raphaël Poggi <poggi.raph@gmail.com> - 2015-11-24 17:10 +0100
          Re: [alsa-devel] [PATCH 4/4] sound: codecs: pcm1792a: introduce  channel side Michael Trimarchi <michael@amarulasolutions.com> - 2015-11-24 21:20 +0100
      Re: [alsa-devel] [PATCH 4/4] sound: codecs: pcm1792a: introduce  channel side Raphaël Poggi <poggi.raph@gmail.com> - 2015-11-24 09:30 +0100

csiph-web