Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1274061

RE: [PATCH v11 3/8] Input: goodix - write configuration data to device

Show all headers | View raw

> -----Original Message-----
> From: Dmitry Torokhov [mailto:dmitry.torokhov@gmail.com]
> Sent: 19 November, 2015 20:21
> To: Tirdea, Irina
> Cc: Bastien Nocera; Aleksei Mamlin; Karsten Merker; linux-input@vger.kernel.org; Mark Rutland; Rob Herring; Purdila, Octavian; linux-
> kernel@vger.kernel.org; devicetree@vger.kernel.org
> Subject: Re: [PATCH v11 3/8] Input: goodix - write configuration data to device
> 
> On Thu, Nov 19, 2015 at 02:26:36PM +0200, Irina Tirdea wrote:
> > +	if (ts->gpiod_int && ts->gpiod_rst) {
> > +		/* update device config */
> > +		ts->cfg_name = kasprintf(GFP_KERNEL, "goodix_%d_cfg.bin",
> > +					 ts->id);
> 
> devm_kasprintf maybe (don't resubmit)?
> 

Yes, using devm_kasprintf would be better.

Thanks,
Irina

> Thanks.
> 
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v11 3/8] Input: goodix - write configuration data to device Irina Tirdea <irina.tirdea@intel.com> - 2015-11-19 13:30 +0100
  Re: [PATCH v11 3/8] Input: goodix - write configuration data to  device Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-19 19:30 +0100
    RE: [PATCH v11 3/8] Input: goodix - write configuration data to  device "Tirdea, Irina" <irina.tirdea@intel.com> - 2015-11-20 14:20 +0100
  Re: [PATCH v11 3/8] Input: goodix - write configuration data to  device Bastien Nocera <hadess@hadess.net> - 2015-11-23 17:40 +0100

csiph-web