Re: [PATCH v5 4/9] perf report: Add callchain value option

From	Arnaldo Carvalho de Melo <acme@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v5 4/9] perf report: Add callchain value option
Date	2015-11-20 13:10 +0100
Message-ID	<qwSFQ-71A-15@gated-at.bofh.it> (permalink)
References	<qsNv3-2fT-3@gated-at.bofh.it> <qsNv5-2fT-33@gated-at.bofh.it> <qwxUK-1Bc-15@gated-at.bofh.it> <qwIQ9-sf-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Em Fri, Nov 20, 2015 at 10:39:47AM +0900, Namhyung Kim escreveu:
> On Thu, Nov 19, 2015 at 10:59:14AM -0300, Arnaldo Carvalho de Melo wrote:
> > Em Mon, Nov 09, 2015 at 02:45:41PM +0900, Namhyung Kim escreveu:
> > > Now -g/--call-graph option supports how to display callchain values.
> > > Possible values are 'percent', 'period' and 'count'.  The percent is
> > > same as before and it's the default behavior.  The period displays the
> > > raw period value rather than the percentage.  The count displays the
> > > number of occurrences.
> > > 
> > >   $ perf report --no-children --stdio -g percent
> > >   ...
> > >     39.93%  swapper  [kernel.vmlinux]  [k] intel_idel
> > >             |
> > >             ---intel_idle
> > >                cpuidle_enter_state
> > >                cpuidle_enter
> > >                call_cpuidle
> > >                cpu_startup_entry
> > >                |
> > >                |--28.63%-- start_secondary
> > >                |
> > >                 --11.30%-- rest_init
> > 
> > So, if I try to do:
> > 
> >   perf report --no-children --stdio -g percent,count
> > 
> > It shows just 'count', i.e. the last of these options, is this an
> > intended limitation?
> > 
> > I'm applying it as-is, but I can see no reason why we wouldn't want to
> > lift this limitation.
> 
> 
> Hmm.. I expected just one value type is used, but yes, we might want
> to support to print multiple values if needed.

And at least to warn the user when more than one out of those options is
asked for and just one of them ends up in the output.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v5 4/9] perf report: Add callchain value option Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-19 15:00 +0100
  Re: [PATCH v5 4/9] perf report: Add callchain value option Namhyung Kim <namhyung@kernel.org> - 2015-11-20 02:40 +0100
    Re: [PATCH v5 4/9] perf report: Add callchain value option Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-20 13:10 +0100

csiph-web