Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1273764

Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions

From Nadav Amit <nadav.amit@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions
Date 2015-11-20 08:50 +0100
Message-ID <qwOCd-4dZ-5@gated-at.bofh.it> (permalink)
References <oRSvU-2LF-35@gated-at.bofh.it> <qwK5z-1aE-5@gated-at.bofh.it> <qwKyC-1Hg-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Wanpeng Li <kernellwp@gmail.com> wrote:

> 2015-11-20 10:52 GMT+08:00 Wanpeng Li <kernellwp@gmail.com>:
>> Hi Paolo,
>> 2015-02-09 17:03 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>:
>>> NoWrite instructions (e.g. cmp or test) never set the "write access"
>>> bit in the error code, even if one of the operands is treated as a
>>> destination.
>> 
>> Sorry to reply to an old commit, btw, could you point out where in SDM
>> describe above?
> 
> I see.

I don’t understand whether you still need my help, so to clarify: on a
page-fault the error code should indicate whether the access was due to a
write access. Previously KVM marked it as “write access” for instructions
such as test and cmp that do not perform write.

Nadav--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH] KVM: x86: emulate: correct page fault error code for  NoWrite instructions Wanpeng Li <kernellwp@gmail.com> - 2015-11-20 04:00 +0100
  Re: [PATCH] KVM: x86: emulate: correct page fault error code for  NoWrite instructions Wanpeng Li <kernellwp@gmail.com> - 2015-11-20 04:30 +0100
    Re: [PATCH] KVM: x86: emulate: correct page fault error code for NoWrite instructions Nadav Amit <nadav.amit@gmail.com> - 2015-11-20 08:50 +0100

csiph-web