Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes

From	Jisheng Zhang <jszhang@marvell.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes
Date	2015-11-20 04:40 +0100
Message-ID	<qwKIi-1Kv-7@gated-at.bofh.it> (permalink)
References	<qvpZf-6BR-3@gated-at.bofh.it> <qvpZg-6BR-29@gated-at.bofh.it> <qwEjw-5Tc-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 19 Nov 2015 21:47:05 +0100
Sebastian Hesselbarth wrote:

> On 16.11.2015 12:09, Jisheng Zhang wrote:
> > The Marvell Berlin BG2Q has 3 watchdogs which are compatible with the
> > snps,dw-wdt driver sit in the sysmgr domain. This patch adds the
> > corresponding device tree nodes.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@marvell.com>
> > ---
> >  arch/arm/boot/dts/berlin2q.dtsi | 24 ++++++++++++++++++++++++
> >  1 file changed, 24 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/berlin2q.dtsi b/arch/arm/boot/dts/berlin2q.dtsi
> > index a3ecde5..fac4315 100644
> > --- a/arch/arm/boot/dts/berlin2q.dtsi
> > +++ b/arch/arm/boot/dts/berlin2q.dtsi
> > @@ -483,6 +483,30 @@
> >  			ranges = <0 0xfc0000 0x10000>;
> >  			interrupt-parent = <&sic>;
> >  
> > +			wdt0: watchdog@1000 {
> > +				compatible = "snps,dw-wdt";
> > +				reg = <0x1000 0x100>;
> > +				clocks = <&refclk>;
> > +				interrupts = <0>;
> > +				status = "disabled";  
> 
> Jisheng,
> 
> as the watchdogs are internal and cannot be clock gated
> at all, how about we remove the status = "disabled" and
> make them always available?

there are two issues here:

1. the dw-wdt can't support multiple variants now. I have rewrite the driver
with watchdog core supplied framework, but the patch isn't sent out and
may be need time to clean up and review.

2. not all dw-wdt devices are available and functional. This depends on
board design and configuration.

So IMHO status=disabled and patch5-8 is necessary, what do you think?

Thanks a lot for review,
Jisheng

> 
> I have applied patches 1-4 with the status property removed.
> This also renders patches 5-8 useless.
> 
> So, for now tentatively
> 
> Appled to berlin/dt and berlin64/dt respectivly
> 
> with status property removed.
> 
> Sebastian
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH RESEND 0/8] {arm|arm64}: berlin: add watchdog support Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100
  [PATCH RESEND 8/8] arm64: dts: berlin: enable wdt0 on the Marvell BG4CT STB board Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100
  [PATCH RESEND 5/8] arm: dts: berlin: enable wdt0 on Sony NSZ-GS7 Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100
  [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100
    Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-19 21:50 +0100
      Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Jisheng Zhang <jszhang@marvell.com> - 2015-11-20 04:40 +0100
        Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-20 21:20 +0100
          Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Jisheng Zhang <jszhang@marvell.com> - 2015-11-23 06:10 +0100
            Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> - 2015-11-28 12:40 +0100
              Re: [PATCH RESEND 1/8] arm: dts: berlin2q: add watchdog nodes Jisheng Zhang <jszhang@marvell.com> - 2015-11-30 14:10 +0100
  [PATCH RESEND 2/8] arm: dts: berlin2cd: add watchdog nodes Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100
  [PATCH RESEND 7/8] arm: dts: berlin: enable wdt0 on the Marvell BG2Q DMP Jisheng Zhang <jszhang@marvell.com> - 2015-11-16 12:20 +0100

csiph-web