Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx
Date	2015-11-19 17:40 +0100
Message-ID	<qwApA-3ke-15@gated-at.bofh.it> (permalink)
References	<qwfbt-6aN-19@gated-at.bofh.it> <qwfbt-6aN-17@gated-at.bofh.it> <qwAfT-3gQ-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Guenter Roeck <linux@roeck-us.net> writes:

>> +	writel(WD_CONFIG_XTAL_IN, dev->base + WD_CONFIG);
>
> What happens if the DISABLE bit was previously set (assuming
> that DISABLE means that the watchdog is disabled) ?
>
> Concern I guess would be the combination of DISABLE being set
> and WD_COUNTER at a value != 0 (say, 1). That might effectively
> auto-enable the watchdog or even reset the system.

There's no sane reason why it would be in that state, but then again
firmware authors are not sane.

How about checking the DISABLE bit, and if it's set turn off the
counter, otherwise leave it running?

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx Mans Rullgard <mans@mansr.com> - 2015-11-18 19:00 +0100
  Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs  SMP86xx/SMP87xx Guenter Roeck <linux@roeck-us.net> - 2015-11-19 17:30 +0100
    Re: [PATCH v2 2/2] watchdog: add support for Sigma Designs SMP86xx/SMP87xx Måns Rullgård <mans@mansr.com> - 2015-11-19 17:40 +0100

csiph-web