Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1272082
| From | Marc Kleine-Budde <mkl@pengutronix.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted |
| Date | 2015-11-18 11:30 +0100 |
| Message-ID | <qw89Y-1BW-7@gated-at.bofh.it> (permalink) |
| References | <qw7QC-1tN-19@gated-at.bofh.it> <qw80h-1y5-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 11/18/2015 11:04 AM, Wenyou Yang wrote:
> Increase the delay time until the value written to INIT can be
> read back to ensure that the previous value written to INIT has
> been accepted.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
The patch looks ok, can you please add to your commit message which SoCs
are affected by this problem.
> ---
>
> drivers/net/can/m_can/m_can.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/can/m_can/m_can.c b/drivers/net/can/m_can/m_can.c
> index ef65517..fd1caa0 100644
> --- a/drivers/net/can/m_can/m_can.c
> +++ b/drivers/net/can/m_can/m_can.c
> @@ -320,7 +320,7 @@ static inline void m_can_config_endisable(const struct m_can_priv *priv,
> bool enable)
> {
> u32 cccr = m_can_read(priv, M_CAN_CCCR);
> - u32 timeout = 10;
> + u32 timeout = 1000;
> u32 val = 0;
>
> if (enable) {
>
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/2] can: m_can: Add CAN clock generated by UPLLCK support Wenyou Yang <wenyou.yang@atmel.com> - 2015-11-18 11:10 +0100
[PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted Wenyou Yang <wenyou.yang@atmel.com> - 2015-11-18 11:20 +0100
Re: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted Marc Kleine-Budde <mkl@pengutronix.de> - 2015-11-18 11:30 +0100
RE: [PATCH 1/2] can: m_can: Increase delay to ensure written INIT accepted "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2015-11-19 05:30 +0100
[PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Wenyou Yang <wenyou.yang@atmel.com> - 2015-11-18 11:20 +0100
Re: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support Marc Kleine-Budde <mkl@pengutronix.de> - 2015-11-18 11:30 +0100
RE: [PATCH 2/2] can: m_can: Add CAN clock generated by UPLLCK support "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2015-11-19 05:30 +0100
csiph-web