Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271862
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages |
| Date | 2015-11-18 07:20 +0100 |
| Message-ID | <qw4g2-7vR-17@gated-at.bofh.it> (permalink) |
| References | <qvUJH-1gq-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Tue, Nov 17, 2015 at 09:01:28PM +0100, Bogicevic Sasa wrote: > This fixes all "Comparison to NULL could be written like..." > messages from checkpatch.pl > > Signed-off-by: Bogicevic Sasa <brutallesale@gmail.com> > --- > drivers/staging/wilc1000/coreconfigurator.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c > index fd7240c..a31ac55 100644 > --- a/drivers/staging/wilc1000/coreconfigurator.c > +++ b/drivers/staging/wilc1000/coreconfigurator.c > @@ -434,7 +434,7 @@ s32 parse_network_info(u8 *pu8MsgBuffer, tstrNetworkInfo **ppstrNetworkInfo) > > /* Get DTIM Period */ > pu8TimElm = get_tim_elm(pu8msa, u16RxLen + FCS_LEN, u8index); > - if (pu8TimElm != NULL) > + if (!pu8TimElm) You are now checking for - if (pu8TimElm == NULL) It should actually be: if (pu8TimElm) regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages Bogicevic Sasa <brutallesale@gmail.com> - 2015-11-17 21:10 +0100
Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-18 07:20 +0100
Re: [PATCH] drivers:staging:wilc1000 Fix comparison to NULL messages Bogicevic Sasa <brutallesale@gmail.com> - 2015-11-18 12:40 +0100
csiph-web