Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270622

Re: [PATCH v2] x86/irq: Probe for PIC presence before allocating descs for legacy IRQs

Show all headers | View raw

On Mon, 16 Nov 2015, Boris Ostrovsky wrote:
> Xen expects legacy interrupts to be there (pretty much for the same reason as
> Hyper-V does) and with this change arch_probe_nr_irqs() returns zero and no
> descriptors are allocated.

Right, because everything which has a PIT gets them and everything
which does not have a PIT does not.

> We can allocate those descriptors as needed in xen_irq_init() (if we know that
> IRQs are legacy), although that would look somewhat ugly and out of place.

Why preallocating them in xen_irq_init()? You simply can remove the
NR_IRQS_LEGACY checks in xen_allocate_irq_gsi/xen_free_irq(), right?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] x86/irq: Probe for PIC presence before allocating  descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-16 22:10 +0100
  Re: [PATCH v2] x86/irq: Probe for PIC presence before allocating  descs for legacy IRQs Thomas Gleixner <tglx@linutronix.de> - 2015-11-16 22:50 +0100
    Re: [PATCH v2] x86/irq: Probe for PIC presence before allocating  descs for legacy IRQs Boris Ostrovsky <boris.ostrovsky@oracle.com> - 2015-11-16 22:50 +0100

csiph-web