Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270559

[PATCH] tools lib traceevents: Fix output of %llu for 64 bit values read on 32 bit machines

Show all headers | View raw

When a long value is read on 32 bit machines for 64 bit output, the parsing
needs to change "%lu" into "%llu", as the value is read natively.

Unfortunately, if "%llu" is already there, the code will add another "l" to
it and fail to parse it properly.

Cc: stable@vger.kernel.org
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
 tools/lib/traceevent/event-parse.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 4d885934b919..43e202bb3ae3 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -4895,7 +4895,7 @@ static void pretty_print(struct trace_seq *s, void *data, int size, struct event
 						break;
 					}
 				}
-				if (pevent->long_size == 8 && ls &&
+				if (pevent->long_size == 8 && ls == 1 &&
 				    sizeof(long) != 8) {
 					char *p;
 
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] tools lib traceevents: Fix output of %llu for 64 bit values  read on 32 bit machines Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 21:40 +0100
  [PATCH v2] tools lib traceevents: Fix output of %llu for 64 bit  values read on 32 bit machines Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 23:30 +0100
    Re: [PATCH v2] tools lib traceevents: Fix output of %llu for 64 bit  values read on 32 bit machines Namhyung Kim <namhyung@kernel.org> - 2015-11-17 01:30 +0100
      Re: [PATCH v2] tools lib traceevents: Fix output of %llu for 64 bit  values read on 32 bit machines Steven Rostedt <rostedt@goodmis.org> - 2015-11-17 03:50 +0100
    Re: [PATCH v2] tools lib traceevents: Fix output of %llu for 64 bit  values read on 32 bit machines Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-11-23 23:20 +0100
    [tip:perf/core] tools lib traceevent:   Fix output of %llu for 64 bit values read on 32 bit machines tip-bot for Steven Rostedt <tipbot@zytor.com> - 2015-11-26 09:30 +0100
  Re: [PATCH] tools lib traceevents: Fix output of %llu for 64 bit  values read on 32 bit machines Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 23:30 +0100

csiph-web