Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1270475
| From | Geert Uytterhoeven <geert@linux-m68k.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH, resend] scsi: advansys: fix big-endian builds |
| Date | 2015-11-16 20:00 +0100 |
| Message-ID | <qvxap-2wq-3@gated-at.bofh.it> (permalink) |
| References | <qvvii-1lM-15@gated-at.bofh.it> <qvwHp-2mv-33@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Nov 16, 2015 at 7:20 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
>> It turns out that the commit that introduced this used the cpu_to_le32()
>> incorrectly on an 8-bit field, which results in the sense_len to always
>> be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
>> byte of the 32-bit intermediate.
>
> More people need to run the sparse checker with -D__CHECK_ENDIAN__ and
> have proper endian annotations?
Sure.
But in this case, it shows up as a normal compiler warning on all big endian
platforms.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH, resend] scsi: advansys: fix big-endian builds Arnd Bergmann <arnd@arndb.de> - 2015-11-16 18:00 +0100
Re: [PATCH, resend] scsi: advansys: fix big-endian builds Russell King - ARM Linux <linux@arm.linux.org.uk> - 2015-11-16 19:30 +0100
Re: [PATCH, resend] scsi: advansys: fix big-endian builds Christoph Hellwig <hch@infradead.org> - 2015-11-16 19:40 +0100
Re: [PATCH, resend] scsi: advansys: fix big-endian builds Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-16 20:00 +0100
Re: [PATCH, resend] scsi: advansys: fix big-endian builds Hannes Reinecke <hare@suse.de> - 2015-11-17 07:50 +0100
Re: [PATCH, resend] scsi: advansys: fix big-endian builds "Martin K. Petersen" <martin.petersen@oracle.com> - 2015-11-18 16:20 +0100
csiph-web