Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270445

Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate

Show all headers | View raw

Hi Joachim,

On Mon, 16 Nov 2015 18:46:44 +0100
Joachim  Eastwood <manabian@gmail.com> wrote:

> Hi Boris
> 
> (Adding Ariel for pwm-lpc18xx-sct)
> 
> On 16 November 2015 at 09:56, Boris Brezillon
> <boris.brezillon@free-electrons.com> wrote:
> > Use pwm_get_xxx() helpers instead of directly accessing the pwm->xxx field.
> > Doing that will ease adaptation of the PWM framework to support atomic
> > update.
> >
> > Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> > ---
> > Patch generated with the following coccinelle script:
> >
> > --->8---
> > virtual patch
> >
> > @@
> > struct pwm_device *p;
> > expression e;
> > @@
> > (
> > -(p)->polarity = e;
> > +pwm_set_polarity((p), e);
> > |
> > -(p)->polarity
> > +pwm_get_polarity((p))
> > |
> > -(p)->period = e;
> > +pwm_set_period((p), e);
> > |
> > -(p)->period
> > +pwm_get_period((p))
> > |
> > -(p)->duty_cycle = e;
> > +pwm_set_duty_cycle((p), e);
> > |
> > -(p)->duty_cycle
> > +pwm_get_duty_cycle((p))
> > )
> > --->8---
> > ---
> >  drivers/pwm/pwm-crc.c         | 2 +-
> >  drivers/pwm/pwm-lpc18xx-sct.c | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pwm/pwm-crc.c b/drivers/pwm/pwm-crc.c
> > index 7101c70..2f88543 100644
> > --- a/drivers/pwm/pwm-crc.c
> > +++ b/drivers/pwm/pwm-crc.c
> > @@ -75,7 +75,7 @@ static int crc_pwm_config(struct pwm_chip *c, struct pwm_device *pwm,
> >                 return -EINVAL;
> >         }
> >
> > -       if (pwm->period != period_ns) {
> > +       if (pwm_get_period((pwm)) != period_ns) {
> >                 int clk_div;
> >
> >                 /* changing the clk divisor, need to disable fisrt */
> > diff --git a/drivers/pwm/pwm-lpc18xx-sct.c b/drivers/pwm/pwm-lpc18xx-sct.c
> > index 9163085..091fa13 100644
> > --- a/drivers/pwm/pwm-lpc18xx-sct.c
> > +++ b/drivers/pwm/pwm-lpc18xx-sct.c
> > @@ -249,7 +249,7 @@ static int lpc18xx_pwm_enable(struct pwm_chip *chip, struct pwm_device *pwm)
> >                            LPC18XX_PWM_EVSTATEMSK(lpc18xx_data->duty_event),
> >                            LPC18XX_PWM_EVSTATEMSK_ALL);
> >
> > -       if (pwm->polarity == PWM_POLARITY_NORMAL) {
> > +       if (pwm_get_polarity((pwm)) == PWM_POLARITY_NORMAL) {
> 
> What is the deal with the double parentheses?
> 
> Think I saw that in some of the other patches as well.

It comes from a typo in my coccinelle script. I already fixed it and
regenerated the faulty patches, so please ignore this aspect while
reviewing (this will be addressed in the next version).

Thanks,

Boris

-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 00/24] pwm: add support for atomic update Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:00 +0100
  [PATCH v4 19/24] pwm: add the PWM initial state retrieval infra Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:00 +0100
  [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:00 +0100
    Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where appropriate Joachim Eastwood <manabian@gmail.com> - 2015-11-16 18:50 +0100
      Re: [PATCH v4 02/24] pwm: use pwm_get_xxx() helpers where  appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 19:20 +0100
  [PATCH v4 13/24] hwmon: pwm-fan: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
    Re: [PATCH v4 13/24] hwmon: pwm-fan: use pwm_get/set_default_xxx()  helpers where appropriate Guenter Roeck <linux@roeck-us.net> - 2015-11-16 17:10 +0100
  [PATCH v4 16/24] pwm: move the enabled/disabled info to pwm_state struct Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 10/24] backlight: pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 11/24] fbdev: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 08/24] leds: pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 15/24] pwm: define a new pwm_state struct Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 14/24] clk: pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
    Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx()  helpers where appropriate Mark Brown <broonie@kernel.org> - 2015-11-16 12:00 +0100
      Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx()  helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 13:30 +0100
        Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx()  helpers where appropriate Mark Brown <broonie@kernel.org> - 2015-11-16 19:50 +0100
          Re: [PATCH v4 09/24] regulator: pwm: use pwm_get/set_default_xxx()  helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 20:30 +0100
  [PATCH v4 07/24] pwm: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 06/24] pwm: introduce default period and polarity concepts Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 03/24] clk: pwm: use pwm_get_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 17/24] backlight: pwm_bl: remove useless call to pwm_set_period Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  [PATCH v4 12/24] misc: max77693: use pwm_get/set_default_xxx() helpers where appropriate Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-11-16 10:10 +0100
  Re: [PATCH v4 00/24] pwm: add support for atomic update Heiko Stübner <heiko@sntech.de> - 2015-11-16 15:50 +0100

csiph-web