Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure

From	Vitaly Kuznetsov <vkuznets@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure
Date	2015-11-16 18:50 +0100
Message-ID	<qvw4G-1TN-3@gated-at.bofh.it> (permalink)
References	<qtYop-8hK-5@gated-at.bofh.it> <qtYoq-8hK-21@gated-at.bofh.it> <qvumf-M6-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Dan Carpenter <dan.carpenter@oracle.com> writes:

> On Thu, Nov 12, 2015 at 12:32:13PM +0100, Vitaly Kuznetsov wrote:
>> @@ -85,10 +86,10 @@ static ssize_t hvt_op_write(struct file *file, const char __user *buf,
>>  		return PTR_ERR(inmsg);
>>  
>>  	if (hvt->on_msg(inmsg, count))
>> -		return -EFAULT;
>> +		ret = -EFAULT;
>
> You fix this leak and then re-introduce it again directly in patch
> 3/4.

Such a shame ... Thanks for noticing!

> Also it might be nice to preserve the error code.
>
> 	ret = hvt->on_msg(inmsg, count);
>
> 	kfree(inmsg);
>
> 	return ret ? ret : count;

It seems on_msg() hooks can only return -EINVAL now but why not
... let's do it in v2.

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-12 12:40 +0100
  Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg()  failure Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-16 17:00 +0100
    Re: [PATCH 1/4] Drivers: hv: utils: fix memory leak on on_msg() failure Vitaly Kuznetsov <vkuznets@redhat.com> - 2015-11-16 18:50 +0100

csiph-web