Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270335

Re: [PATCH] ftrace/x86: Fix missing ops arg on static function tracing

Show all headers | View raw

On Mon, 16 Nov 2015 10:54:53 -0500
Steven Rostedt <rostedt@goodmis.org> wrote:

> This isn't needed, nor will the parameter be used if added. A comment
> should probably be added here instead.
> 
> /*
>  * When DYNAMIC_FTRACE is not defined, ARCH_SUPPORTS_FTRACE_OPS is not
>  * set (see include/asm/ftrace.h). Only the ip and parent ip are used

Probably should also add "and include/linux/ftrace.h" as that's where
the ARCH_SUPPORTS_FTRACE_OPS is described.

-- Steve

>  * and the list function is called when function tracing is enabled.
>  */
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] ftrace/x86: Fix missing ops arg on static function tracing Namhyung Kim <namhyung@kernel.org> - 2015-11-14 10:40 +0100
  Re: [PATCH] ftrace/x86: Fix missing ops arg on static function  tracing Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 17:00 +0100
  Re: [PATCH] ftrace/x86: Fix missing ops arg on static function  tracing Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 17:00 +0100
    Re: [PATCH] ftrace/x86: Fix missing ops arg on static function  tracing Steven Rostedt <rostedt@goodmis.org> - 2015-11-16 17:30 +0100
    Re: [PATCH] ftrace/x86: Fix missing ops arg on static function  tracing Namhyung Kim <namhyung@kernel.org> - 2015-11-17 00:50 +0100

csiph-web