Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1270291
| From | "H. Nikolaus Schaller" <hns@goldelico.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings |
| Date | 2015-11-16 16:40 +0100 |
| Message-ID | <qvu2S-EC-21@gated-at.bofh.it> (permalink) |
| References | <qutix-2JT-5@gated-at.bofh.it> <qutiz-2JT-27@gated-at.bofh.it> <qvt6P-8uH-53@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
HI, Am 16.11.2015 um 15:37 schrieb Grazvydas Ignotas <notasas@gmail.com>: > Hi, > > On Fri, Nov 13, 2015 at 10:35 PM, H. Nikolaus Schaller > <hns@goldelico.com> wrote: >> The standard touch screen bindings [1] replace the private ti,swap-xy >> with touchscreen-swaped-x-y. And for the Openpandora we use >> touchscreen-size etc. to match the LCD screen size. >> >> [1]: Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt >> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> arch/arm/boot/dts/omap3-lilly-a83x.dtsi | 2 +- >> arch/arm/boot/dts/omap3-pandora-common.dtsi | 17 +++++++++++++---- >> arch/arm/boot/dts/omap3-panel-sharp-ls037v7dw01.dtsi | 2 +- >> 3 files changed, 15 insertions(+), 6 deletions(-) >> >> diff --git a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi >> index d0dd036..01dae66 100644 >> --- a/arch/arm/boot/dts/omap3-lilly-a83x.dtsi >> +++ b/arch/arm/boot/dts/omap3-lilly-a83x.dtsi >> @@ -325,7 +325,7 @@ >> ti,y-max = /bits/ 16 <3600>; >> ti,x-plate-ohms = /bits/ 16 <80>; >> ti,pressure-max = /bits/ 16 <255>; >> - ti,swap-xy; >> + touchscreen-swapped-x-y; >> >> linux,wakeup; >> }; >> diff --git a/arch/arm/boot/dts/omap3-pandora-common.dtsi b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> index f672a04..9497cc6 100644 >> --- a/arch/arm/boot/dts/omap3-pandora-common.dtsi >> +++ b/arch/arm/boot/dts/omap3-pandora-common.dtsi >> @@ -696,10 +696,19 @@ >> pendown-gpio = <&gpio3 30 0>; >> vcc-supply = <&vaux4>; >> >> - ti,x-min = /bits/ 16 <0>; >> - ti,x-max = /bits/ 16 <8000>; >> - ti,y-min = /bits/ 16 <0>; >> - ti,y-max = /bits/ 16 <4800>; >> + touchscreen-size-x = <800>; >> + touchscreen-size-y = <480>; >> + touchscreen-max-pressure = <1000>; >> + touchscreen-fuzz-x = <16>; >> + touchscreen-fuzz-y = <16>; >> + touchscreen-fuzz-pressure = <10>; >> + touchscreen-inverted-x; >> + touchscreen-inverted-y; >> + >> + ti,x-min = /bits/ 16 <160>; >> + ti,x-max = /bits/ 16 <3900>; >> + ti,y-min = /bits/ 16 <220>; >> + ti,y-max = /bits/ 16 <3750>; > > I'm not sure this is a good idea, there have been at least 3 different > batches of LCDs which slightly different touchscreens attached, with > such thresholds we might end up with unreachable touchscreen points on > some units. If I understand right, calibration won't help if for some > screen locations ADC reading goes below/above these min/max thresholds > on some specific units? If so there should probably be at least 10% > margin in either case to make calibration useful. Ok, then someone owning all variants should test and we should use the min/max values we find. I.e. the touch with the biggest ADC value range. All others have smaller screens which can be calibrated in user space. But 10% is good enough to boot and start manual calibration. Alternatively, we can set them to 0 and 4095 (or remove them to use defaults). BR and thanks, Nikolaus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/8] drivers: touchscreen: tsc2007 and ads7846/tsc2046 improvements (use common touchscreen bindings, pre-calibration, spi fix and provide iio raw values) "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
[PATCH v2 2/8] drivers:input:tsc2007: send pendown and penup only once like ads7846(+tsc2046) driver does "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
[PATCH v2 6/8] drivers:input:ads7846(+tsc2046): recognise old binding for coordinate flipping "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
Re: [PATCH v2 6/8] drivers:input:ads7846(+tsc2046): recognise old binding for coordinate flipping Rob Herring <robh+dt@kernel.org> - 2015-11-15 03:20 +0100
Re: [PATCH v2 6/8] drivers:input:ads7846(+tsc2046): recognise old binding for coordinate flipping "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-15 12:00 +0100
[PATCH v2 3/8] drivers:input:tsc2007: add iio interface to read external ADC input, temperature and raw conversion values "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
[PATCH v2 4/8] DT:omap3+tsc2007: use new common touchscreen bindings "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
[PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings Grazvydas Ignotas <notasas@gmail.com> - 2015-11-16 15:40 +0100
Re: [PATCH v2 8/8] DT:omap3+ads7846: use new common touchscreen bindings "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-16 16:40 +0100
[PATCH v2 5/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
Re: [PATCH v2 5/8] drivers:input:ads7846(+tsc2046): add new common binding names, pre-calibration and flipping Sebastian Reichel <sre@kernel.org> - 2015-11-13 23:40 +0100
[PATCH v2 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-13 21:40 +0100
Re: [PATCH v2 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation Rob Herring <robh@kernel.org> - 2015-11-15 03:20 +0100
Re: [PATCH v2 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation "H. Nikolaus Schaller" <hns@goldelico.com> - 2015-11-15 12:40 +0100
csiph-web