Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270275

Re: [PATCH v2] hid: enable hid device to suspend/resume asynchronously

Show all headers | View raw

Hi Jiri,

Any comments about this patch?

After enabling the HID devices suspend/resume asynchronously on ASUS T100TA(Baytrail-T platform), the system suspend-to-idle/resume time is reduced about 20ms. Although this improvement is not very significant. But, if the suspend/resume operation of HID devices is very time-consuming on some other platforms, this patch can improve significantly system suspend/resume speed on these platforms. 



Thanks,
Zhonghui 



On 9/24/2015 2:06 PM, Fu, Zhonghui wrote:
> Now, PM core supports asynchronous suspend/resume mode for devices
> during system suspend/resume, and the power state transition of one
> device may be completed in separate kernel thread. PM core ensures
> all power state transition timing dependency between devices. This
> patch enables hid devices to suspend/resume asynchronously. This
> will take advantage of multicore and improve system suspend/resume
> speed.
>
> Signed-off-by: Zhonghui Fu <zhonghui.fu@linux.intel.com>
> ---
> Changes in v2:
> - Amend commit message.
>
>  drivers/hid/hid-core.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
> index 70a11ac..357f3a3 100644
> --- a/drivers/hid/hid-core.c
> +++ b/drivers/hid/hid-core.c
> @@ -2652,6 +2652,7 @@ struct hid_device *hid_allocate_device(void)
>  	device_initialize(&hdev->dev);
>  	hdev->dev.release = hid_device_release;
>  	hdev->dev.bus = &hid_bus_type;
> +	device_enable_async_suspend(&hdev->dev);
>  
>  	hid_close_report(hdev);
>  
> -- 1.7.1
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] hid: enable hid device to suspend/resume asynchronously "Fu, Zhonghui" <zhonghui.fu@linux.intel.com> - 2015-11-16 16:20 +0100
  Re: [PATCH v2] hid: enable hid device to suspend/resume  asynchronously Jiri Kosina <jikos@kernel.org> - 2015-11-16 16:30 +0100
    Re: [PATCH v2] hid: enable hid device to suspend/resume asynchronously "Fu, Zhonghui" <zhonghui.fu@linux.intel.com> - 2015-11-23 07:10 +0100

csiph-web