Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1270242

Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro

From Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups linux.kernel
Subject Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro
Date 2015-11-16 15:40 +0100
Message-ID <qvt6O-8uH-41@gated-at.bofh.it> (permalink)
References <quIKD-4qQ-23@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Nov 14, 2015 at 06:43:23PM +0530, Ranjith Thangavel wrote:
> @@ -221,11 +223,11 @@ static int ni6527_intr_cmdtest(struct comedi_device *dev,
>  
>  	/* Step 1 : check if triggers are trivially valid */
>  
> -	err |= comedi_check_trigger_src(&cmd->start_src, TRIG_NOW);
> -	err |= comedi_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER);
> -	err |= comedi_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW);
> -	err |= comedi_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
> -	err |= comedi_check_trigger_src(&cmd->stop_src, TRIG_COUNT);
> +	err |= cfc_check_trigger_src(&cmd->start_src, TRIG_NOW);
> +	err |= cfc_check_trigger_src(&cmd->scan_begin_src, TRIG_OTHER);
> +	err |= cfc_check_trigger_src(&cmd->convert_src, TRIG_FOLLOW);
> +	err |= cfc_check_trigger_src(&cmd->scan_end_src, TRIG_COUNT);
> +	err |= cfc_check_trigger_src(&cmd->stop_src, TRIG_COUNT);
>  
>  	if (err)
>  		return 1;

This part looks to be included by mistake.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] comedi: ni_6527: Fix coding style - use BIT macro Ranjith Thangavel <ranjithece24@gmail.com> - 2015-11-14 14:10 +0100
  Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro Dan Carpenter <dan.carpenter@oracle.com> - 2015-11-16 15:40 +0100
  Re: [PATCH] comedi: ni_6527: Fix coding style - use BIT macro Ian Abbott <abbotti@mev.co.uk> - 2015-11-18 17:10 +0100

csiph-web