Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1270044

Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface

From Felipe Ferreri Tonello <eu@felipetonello.com>
Newsgroups linux.kernel
Subject Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface
Date 2015-11-16 12:50 +0100
Message-ID <qvqsi-6MZ-35@gated-at.bofh.it> (permalink)
References <qtln3-8aF-7@gated-at.bofh.it> <qtln4-8aF-19@gated-at.bofh.it> <qtm9s-gB-11@gated-at.bofh.it> <qtA2J-Xz-1@gated-at.bofh.it> <quhKq-3UK-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

Hi Clemens,

On 13/11/15 08:11, Clemens Ladisch wrote:
> Felipe Ferreri Tonello wrote:
>> On 10/11/15 18:43, Sergei Shtylyov wrote:
>>> On 11/10/2015 08:52 PM, Felipe F. Tonello wrote:
>>>> @@ -75,6 +75,7 @@ struct f_midi {
>>>>       struct usb_ep        *in_ep, *out_ep;
>>>>       struct snd_card        *card;
>>>>       struct snd_rawmidi    *rmidi;
>>>> +    u8                    ms_id;
>>>
>>>   Why 'ms_id' is not aligned with the above field names?
>>
>> It is actually aligned.
> 
> It's not in the original mail, which contains tab characters.
> 
>> Here is from my local git diff:
>>
>> @@ -75,6 +75,7 @@ struct f_midi {
>>     struct usb_ep       *in_ep, *out_ep;
>>     struct snd_card     *card;
>>     struct snd_rawmidi  *rmidi;
>> +   u8                  ms_id;
> 
> Apparently, you're using four spaces per tab.  Linux uses eight.

Yes. I'll fix that.

-- 
Felipe

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for MIDIStreaming interface "Felipe F. Tonello" <eu@felipetonello.com> - 2015-11-10 19:00 +0100
  Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-10 19:50 +0100
    Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Felipe Ferreri Tonello <eu@felipetonello.com> - 2015-11-11 10:40 +0100
      Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> - 2015-11-11 19:10 +0100
      Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Clemens Ladisch <clemens@ladisch.de> - 2015-11-13 09:20 +0100
        Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Felipe Ferreri Tonello <eu@felipetonello.com> - 2015-11-16 12:50 +0100
  Re: [PATCH v5 6/7] usb: gadget: f_midi: set altsettings only for  MIDIStreaming interface Clemens Ladisch <clemens@ladisch.de> - 2015-11-13 09:20 +0100

csiph-web