Re: [PATCH] dma: at_hdmac: use %pad format string for dma_addr_t

Path	csiph.com!au2pb.net!feeder.erje.net!1.eu.feeder.erje.net!border1.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod
From	Vinod Koul <vinod.koul@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] dma: at_hdmac: use %pad format string for dma_addr_t
Date	Mon, 16 Nov 2015 04:50:02 +0100
Message-ID	<qviXM-242-9@gated-at.bofh.it> (permalink)
References	<qu0Tg-1x8-17@gated-at.bofh.it>
X-Original-To	Arnd Bergmann <arnd@arndb.de>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,300,1444719600"; d="scan'208";a="839357767"
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	22
Organization	linux.* mail to news gateway
X-Original-Cc	dmaengine@vger.kernel.org, Ludovic Desroches <ludovic.desroches@atmel.com>, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 16 Nov 2015 09:22:20 +0530
X-Original-Message-ID	<20151116035219.GB25173@localhost>
X-Original-References	<3938068.0vDFThTK2h@wuerfel>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1269841

Show key headers only | View raw

On Thu, Nov 12, 2015 at 03:18:22PM +0100, Arnd Bergmann wrote:
> dma_addr_t may be defined as 32 or 64 bit depending on configuration,
> so it cannot be printed using the normal format strings, as
> gcc correctly warns:
> 
> drivers/dma/at_hdmac.c: In function 'atc_prep_dma_interleaved':
> drivers/dma/at_hdmac.c:731:28: warning: format '%x' expects argument of type 'unsigned int', but argument 4 has type 'dma_addr_t {aka long long unsigned int}' [-Wformat=]
> 
> This changes the format strings to use the special "%pad" format
> string that prints a dma_addr_t, and changes the arguments so we
> pass the address by reference as required.
> 

Applied, thanks

-- 
~Vinod
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] dma: at_hdmac: use %pad format string for dma_addr_t Arnd Bergmann <arnd@arndb.de> - 2015-11-12 15:20 +0100
  Re: [PATCH] dma: at_hdmac: use %pad format string for dma_addr_t Nicolas Ferre <nicolas.ferre@atmel.com> - 2015-11-12 15:50 +0100
  Re: [PATCH] dma: at_hdmac: use %pad format string for dma_addr_t Vinod Koul <vinod.koul@intel.com> - 2015-11-16 04:50 +0100

csiph-web