Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1269839
| From | Masahiro Yamada <yamada.masahiro@socionext.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" |
| Date | 2015-11-16 04:50 +0100 |
| Message-ID | <qviXL-242-1@gated-at.bofh.it> (permalink) |
| References | <qrqKe-5R7-5@gated-at.bofh.it> <qrqKe-5R7-17@gated-at.bofh.it> <qrt5o-7ln-25@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Linus 2015-11-05 22:40 GMT+09:00 Linus Walleij <linus.walleij@linaro.org>: > On Thu, Nov 5, 2015 at 12:15 PM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: > >> ARCH_SUNXI selects RESET_CONTROLLER. >> The dependency "depends on RESET_CONTROLLER" is already met. >> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > NACK, this pin controller needs that as dependency, I don't worry > that it's overspecified. > > They both do this: > #include <linux/reset.h> > > And the object should specify its dependencies, not rely on them > being implicitly available. > > The dep is there for human readers too, not just machines. And to > them, this is helpful information. How strict we should follow this rule? Many drivers depend on OF, but do they all have "depends on OF"? -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-05 12:20 +0100
Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Linus Walleij <linus.walleij@linaro.org> - 2015-11-05 14:50 +0100
Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Linus Walleij <linus.walleij@linaro.org> - 2015-11-05 15:10 +0100
Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-11-16 04:50 +0100
Re: [RFC PATCH 4/7] pinctrl: sunxi: remove redundant "depends on RESET_CONTROLLER" Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 15:10 +0100
csiph-web