[PATCH 4/8] stop_machine: change stop_one_cpu() to rely on cpu_stop_queue_work()

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH 4/8] stop_machine: change stop_one_cpu() to rely on cpu_stop_queue_work()
Date	Sun, 15 Nov 2015 19:40:03 +0100
Message-ID	<qvanx-4YI-41@gated-at.bofh.it> (permalink)
References	<qvanw-4YI-9@gated-at.bofh.it>
X-Original-To	Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <peterz@infradead.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.18 (2008-05-17)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.24
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	35
Organization	linux.* mail to news gateway
X-Original-Cc	Milos Vyletel <milos@redhat.com>, Prarit Bhargava <prarit@redhat.com>, Tejun Heo <tj@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 15 Nov 2015 20:33:20 +0100
X-Original-Message-ID	<20151115193320.GA8259@redhat.com>
X-Original-References	<20151115193254.GA8225@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1269738

Show key headers only | View raw

Change stop_one_cpu() to return -ENOENT if cpu_stop_queue_work() fails.
Otherwise we know that ->executed must be true after wait_for_completion()
so we can just return done.ret.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
---
 kernel/stop_machine.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index 0ec1f16..68b73c4 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -128,9 +128,11 @@ int stop_one_cpu(unsigned int cpu, cpu_stop_fn_t fn, void *arg)
 	struct cpu_stop_work work = { .fn = fn, .arg = arg, .done = &done };
 
 	cpu_stop_init_done(&done, 1);
-	cpu_stop_queue_work(cpu, &work);
+	if (!cpu_stop_queue_work(cpu, &work))
+		return -ENOENT;
 	wait_for_completion(&done.completion);
-	return done.executed ? done.ret : -ENOENT;
+	WARN_ON(!done.executed);
+	return done.ret;
 }
 
 /* This controls the threads on each CPU. */
-- 
1.5.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 4/8] stop_machine: change stop_one_cpu() to rely on  cpu_stop_queue_work() Oleg Nesterov <oleg@redhat.com> - 2015-11-15 19:40 +0100
  [tip:sched/core] stop_machine: Change stop_one_cpu()   to rely on cpu_stop_queue_work() tip-bot for Oleg Nesterov <tipbot@zytor.com> - 2015-11-23 17:30 +0100

csiph-web