Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup
Date	2015-11-17 22:30 +0100
Message-ID	<qvVZ8-20O-29@gated-at.bofh.it> (permalink)
References	<qvUqm-TY-5@gated-at.bofh.it> <qvUqn-TY-33@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Tejun Heo <tj@kernel.org>
Date: Tue, 17 Nov 2015 14:40:39 -0500

> In preparation, this patch adds sock->sk_cgroup which points to the
> associated cgroup.  A sock is associated on creation and stays
> associated to the same cgroup until freed; unfortunately, this ends up
> adding another cgroup field to struct sock on top of sk_cgrp_prioidx
> and sk_classid.  I tried to think of a way to somehow overload the
> existing fields but couldn't come up with a reasonable one.

sk->sk_cgrp_prioidx is simply sk->sk_cgroup->id, is it not?

We really need to consolidate this before we stuff even more members
into the socket for control group support, sorry.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCHSET] netfilter, cgroup: implement xt_cgroup2 match Tejun Heo <tj@kernel.org> - 2015-11-17 20:50 +0100
  [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Tejun Heo <tj@kernel.org> - 2015-11-17 20:50 +0100
    Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup David Miller <davem@davemloft.net> - 2015-11-17 22:30 +0100
      Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Tejun Heo <tj@kernel.org> - 2015-11-17 22:40 +0100
        Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 22:50 +0100
          Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Tejun Heo <tj@kernel.org> - 2015-11-17 23:20 +0100
        Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup David Miller <davem@davemloft.net> - 2015-11-17 22:50 +0100
    Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Daniel Borkmann <daniel@iogearbox.net> - 2015-11-17 22:50 +0100
      Re: [PATCH 4/5] sock, cgroup: add sock->sk_cgroup Tejun Heo <tj@kernel.org> - 2015-11-17 23:30 +0100
  [PATCH 1/5] cgroup: record ancestor IDs and reimplement cgroup_is_descendant() using it Tejun Heo <tj@kernel.org> - 2015-11-17 20:50 +0100
    Re: [PATCH 1/5] cgroup: record ancestor IDs and reimplement  cgroup_is_descendant() using it Jan Engelhardt <jengelh@inai.de> - 2015-11-18 00:00 +0100
      Re: [PATCH 1/5] cgroup: record ancestor IDs and reimplement  cgroup_is_descendant() using it Tejun Heo <tj@kernel.org> - 2015-11-18 00:10 +0100

csiph-web