Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1271507

Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

From Moritz Fischer <moritz.fischer@ettus.com>
Newsgroups linux.kernel
Subject Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.
Date 2015-11-17 19:10 +0100
Message-ID <qvSRB-8wu-31@gated-at.bofh.it> (permalink)
References <qvS5b-7Xf-11@gated-at.bofh.it> <qvSRB-8wu-33@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Michal,

On Tue, Nov 17, 2015 at 9:53 AM, Michal Simek <michal.simek@xilinx.com> wrote:

>> +#ifdef CONFIG_PM
>
> remove this

Will do.
>
>> +static int zynq_fpga_runtime_suspend(struct device *dev)
>
> add __maybe_unused here

Will do.

>> +static int zynq_fpga_runtime_resume(struct device *dev)
>
> and here

Will do.

>> +}
>> +
>> +#endif
>
> and remove this.

Will do.

> Body has nothing specific what it is available only for CONFIG_PM that's
> why it should just work.

You're right. I'll resubmit once other people took another look. Not
high priority ;-)

Cheers,

Moritz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}. Moritz Fischer <moritz.fischer@ettus.com> - 2015-11-17 18:20 +0100
  Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}. Moritz Fischer <moritz.fischer@ettus.com> - 2015-11-17 19:10 +0100
  Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}. Michal Simek <michal.simek@xilinx.com> - 2015-11-17 19:30 +0100

csiph-web