Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk()

From	Paolo Bonzini <pbonzini@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead of pte_list_walk()
Date	2015-11-17 19:00 +0100
Message-ID	<qvSHV-8dG-15@gated-at.bofh.it> (permalink)
References	<qtYoq-8hK-11@gated-at.bofh.it> <qtYoq-8hK-9@gated-at.bofh.it> <quuHF-3K0-37@gated-at.bofh.it> <qvdbI-6N6-25@gated-at.bofh.it> <qvibo-1rq-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16/11/2015 03:51, Takuya Yoshikawa wrote:
> What kvm_mmu_mark_parents_unsync() does is:
> 
>   for each p_i in sp->parent_ptes rmap chain
>     mark_unsync(p_i);
> 
> Then, mark_unsync() finds the parent sp including that p_i to
> set ->unsync_child_bitmap and increment ->unsync_children if
> necessary.  It may also call kvm_mmu_mark_parents_unsync()
> recursively.

I agree.  sp->parent_ptes goes up one level from sp;
kvm_mmu_mark_parents_unsync(sp) visits the level above sp, while
mark_unsync(sp) visit sp and all the levels above it.

Calling mark_unsync(parent_pte) is enough to complete the visit, after
kvm_mmu_mark_parents_unsync has already processed the level above sp.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH 05/10] KVM: x86: MMU: Use for_each_rmap_spte macro instead  of pte_list_walk() Paolo Bonzini <pbonzini@redhat.com> - 2015-11-17 19:00 +0100

csiph-web