Re: [PATCH 1/8] stop_machine: cpu_stopper_thread() must check done != NULL

From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/8] stop_machine: cpu_stopper_thread() must check done != NULL
Date	2015-11-17 18:00 +0100
Message-ID	<qvRLS-7AN-39@gated-at.bofh.it> (permalink)
References	<qvanw-4YI-9@gated-at.bofh.it> <qvanx-4YI-59@gated-at.bofh.it> <qvxap-2wq-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/16, Tejun Heo wrote:
>
> On Sun, Nov 15, 2015 at 08:33:11PM +0100, Oleg Nesterov wrote:
> > stop_one_cpu_nowait(fn) will crash the kernel if the callback returns
> > nonzero, work->done == NULL in this case.
> >
> > This needs more cleanups, cpu_stop_signal_done() is called right after
> > we check done != NULL and it does the same check.
> >
> > Signed-off-by: Oleg Nesterov <oleg@redhat.com>
>
> Acked-by: Tejun Heo <tj@kernel.org>

Thanks!

> cc stable?

Yes, I was going to add -stable initially. And perhaps this makes sense
anyway, the patch is really trivial.

OTOH I have checked the history, none of cpu_stop_signal_done's callbacks
ever returned non-zero, so I decided to not spam -stable.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/8] stop_machine: cpu_stopper_thread() must check done  != NULL Tejun Heo <tj@kernel.org> - 2015-11-16 20:00 +0100
  Re: [PATCH 1/8] stop_machine: cpu_stopper_thread() must check done  != NULL Oleg Nesterov <oleg@redhat.com> - 2015-11-17 18:00 +0100

csiph-web