Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1271248
| From | Marcel Holtmann <marcel@holtmann.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" |
| Date | 2015-11-17 15:10 +0100 |
| Message-ID | <qvP7l-64d-49@gated-at.bofh.it> (permalink) |
| References | (14 earlier) <mSsDN-4wa-63@gated-at.bofh.it> <mSsDN-4wa-65@gated-at.bofh.it> <mSsDN-4wa-33@gated-at.bofh.it> <qvry3-7qr-33@gated-at.bofh.it> <qvskq-7Yr-31@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Stefan, >> The kfree_skb() function tests whether its argument is NULL and then >> returns immediately. Thus the test around the call is not needed. >> >> This issue was detected by using the Coccinelle software. >> >> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> >> --- >> drivers/net/ieee802154/atusb.c | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/drivers/net/ieee802154/atusb.c b/drivers/net/ieee802154/atusb.c >> index 199a94a..b1cd865 100644 >> --- a/drivers/net/ieee802154/atusb.c >> +++ b/drivers/net/ieee802154/atusb.c >> @@ -310,8 +310,7 @@ static void atusb_free_urbs(struct atusb *atusb) >> urb = usb_get_from_anchor(&atusb->idle_urbs); >> if (!urb) >> break; >> - if (urb->context) >> - kfree_skb(urb->context); >> + kfree_skb(urb->context); >> usb_free_urb(urb); >> } >> } > > Acked-by: Stefan Schmidt <stefan@osg.samsung.com> for some reason I am missing the original patch, can someone resend it please. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" SF Markus Elfring <elfring@users.sourceforge.net> - 2015-11-16 14:00 +0100
Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-11-16 14:50 +0100
Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Marcel Holtmann <marcel@holtmann.org> - 2015-11-17 15:10 +0100
Re: [PATCH] ieee802154-atusb: Delete an unnecessary check before the function call "kfree_skb" Stefan Schmidt <stefan@osg.samsung.com> - 2015-11-17 17:20 +0100
csiph-web