Re: [PATCH] pinctrl: imx1-core: add missing of_node_put

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] pinctrl: imx1-core: add missing of_node_put
Date	2015-11-17 15:10 +0100
Message-ID	<qvP7j-64d-17@gated-at.bofh.it> (permalink)
References	<quWNz-4Tu-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Nov 15, 2015 at 5:04 AM, Vaishali Thakkar
<vthakkar1994@gmail.com> wrote:

> for_each_child_of_node performs an of_node_get on each iteration,
> so of_node_put is required on break out of the loop.
>
> This is done using Coccinelle. And semantic patch used for this is
> as follows:
>
> @@
> expression root,e;
> local idexpression child;
> @@
>
>  for_each_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>

Patch applied for fixes, thanks!

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] pinctrl: imx1-core: add missing of_node_put Linus Walleij <linus.walleij@linaro.org> - 2015-11-17 15:10 +0100

csiph-web