[PATCH 1/5] Input: db9 - clear unused function pointers

From	Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 1/5] Input: db9 - clear unused function pointers
Date	2015-11-17 14:50 +0100
Message-ID	<qvONX-5HC-11@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

db9_parport_cb is a local uninitialized structure and the member
function pointers will be pointing to arbitrary locations unless they
are cleared.

Fixes: 2260c419b52b ("Input: db9 - use parallel port device model")
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/input/joystick/db9.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/input/joystick/db9.c b/drivers/input/joystick/db9.c
index 932d073..da32609 100644
--- a/drivers/input/joystick/db9.c
+++ b/drivers/input/joystick/db9.c
@@ -592,6 +592,7 @@ static void db9_attach(struct parport *pp)
 		return;
 	}
 
+	memset(&db9_parport_cb, 0, sizeof(db9_parport_cb));
 	db9_parport_cb.flags = PARPORT_FLAG_EXCL;
 
 	pd = parport_register_dev_model(pp, "db9", &db9_parport_cb, port_idx);
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] Input: db9 - clear unused function pointers Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-17 14:50 +0100
  Re: [PATCH 1/5] Input: db9 - clear unused function pointers Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-11-17 19:10 +0100
    Re: [PATCH 1/5] Input: db9 - clear unused function pointers Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2015-11-20 09:40 +0100

csiph-web