Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init

From	Daniel Lezcano <daniel.lezcano@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init
Date	2015-11-17 13:30 +0100
Message-ID	<qvNyy-4XK-21@gated-at.bofh.it> (permalink)
References	<qukfh-5kp-33@gated-at.bofh.it> <qulEl-6kY-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 11/13/2015 01:20 PM, Marc Gonzalez wrote:
> On 13/11/2015 11:58, Daniel Lezcano wrote:
>
>> The current code to initialize, register and read the clocksource is
>> already factored out in mmio.c via the clocksource_mmio_init function.
>>
>> Factor out the code with the clocksource_mmio_init function.
>
> The reason I didn't like clocksource_mmio_init() is because it exports
> 4 generic accessors.
>
> I guess this function makes more sense when all platforms are using it,
> in an ARCH_MULTIPLATFORM kernel. (Also the accessors are probably quite
> small, so the waste is probably minimal.)

Hi Marc,

it is not clear for me if you agree with this patch or not. Can you 
clarify ?

Thanks

   -- Daniel

-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by  clocksource_mmio_init Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-17 13:30 +0100
  Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by  clocksource_mmio_init Marc Gonzalez <marc_gonzalez@sigmadesigns.com> - 2015-11-17 13:50 +0100
    Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by clocksource_mmio_init Måns Rullgård <mans@mansr.com> - 2015-11-17 14:10 +0100
    Re: [PATCH] clocksource/drivers/tango-xtal: Replace code by  clocksource_mmio_init Daniel Lezcano <daniel.lezcano@linaro.org> - 2015-11-17 14:20 +0100

csiph-web