Re: [PATCH v2] usb: chipidea: removing of_find_property

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] usb: chipidea: removing of_find_property
Date	2015-11-17 12:50 +0100
Message-ID	<qvMVR-4uY-35@gated-at.bofh.it> (permalink)
References	<qvMCu-4n1-17@gated-at.bofh.it> <qvMVQ-4uY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Saurabh Sengar <saurabh.truth@gmail.com> writes:

> call to of_find_property() before of_property_read_u32() is unnecessary.
> of_property_read_u32() anyway calls to of_find_property() only.
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> v2: removed pval variable
>  drivers/usb/chipidea/core.c | 61 +++++++++++++++++++--------------------------
>  1 file changed, 26 insertions(+), 35 deletions(-)
>
> diff --git a/drivers/usb/chipidea/core.c b/drivers/usb/chipidea/core.c
> index 965d0e2..916a20d 100644
> --- a/drivers/usb/chipidea/core.c
> +++ b/drivers/usb/chipidea/core.c
> @@ -688,52 +688,43 @@ static int ci_get_platdata(struct device *dev,
>  	if (usb_get_maximum_speed(dev) == USB_SPEED_FULL)
>  		platdata->flags |= CI_HDRC_FORCE_FULLSPEED;
>
> -	if (of_find_property(dev->of_node, "phy-clkgate-delay-us", NULL))
> -		of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
> -				     &platdata->phy_clkgate_delay_us);
> +	if (!of_property_read_u32(dev->of_node, "phy-clkgate-delay-us",
> +				     &platdata->phy_clkgate_delay_us))
>
>  	platdata->itc_setting = 1;

Drop that if().  Since we're ignoring of_property_read_u32() failing,
there is no need to test its return value, and code above incorrectly
makes the next statement conditional.

-- 
Måns Rullgård
mans@mansr.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-17 12:10 +0100
  Re: [PATCH] usb: chipidea: removing of_find_property Måns Rullgård <mans@mansr.com> - 2015-11-17 12:30 +0100
    [PATCH v2] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-17 12:50 +0100
      Re: [PATCH v2] usb: chipidea: removing of_find_property Måns Rullgård <mans@mansr.com> - 2015-11-17 12:50 +0100
        [PATCH v3] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-17 13:00 +0100
          Re: [PATCH v3] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-18 05:10 +0100
            [PATCH v4] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-18 05:20 +0100
              Re: [PATCH v4] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-18 07:20 +0100
                Re: [PATCH v4] usb: chipidea: removing of_find_property Saurabh Sengar <saurabh.truth@gmail.com> - 2015-11-18 08:50 +0100

csiph-web