Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs

From	Geert Uytterhoeven <geert@linux-m68k.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 net-next] net/core: ensure features get disabled on new lower devs
Date	2015-11-17 11:10 +0100
Message-ID	<qvLn3-3DL-7@gated-at.bofh.it> (permalink)
References	<qqQx4-7Ef-15@gated-at.bofh.it> <qqXyx-3Tn-1@gated-at.bofh.it> <qriWl-BZ-5@gated-at.bofh.it> <quapz-7DK-7@gated-at.bofh.it> <qvKr0-31p-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 17, 2015 at 10:02 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Fri, Nov 13, 2015 at 1:26 AM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 04/11/15 18:56, David Miller wrote:
>>>> Fixes: fd867d51f889 ("net/core: generic support for disabling netdev features down stack")
>>>  ...
>>>> Reported-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>>>> Signed-off-by: Jarod Wilson <jarod@redhat.com>
>>>> ---
>>>> v2: Based on suggestions from Alex, and with not changing err to ret, this
>>>> patch actually becomes quite minimal and doesn't ugly up the code much.
>>>
>>> Applied, thanks.
>>
>> This causes some warnings to be displayed for DSA stacked devices:
>
> And a few more:
>
> sh-eth ee700000.ethernet eth0: set_features() failed (-1); wanted
> 0x0000000000004000, left 0x0000000000004800
> g_ether gadget usb0: set_features() failed (-1); wanted
> 0x0000000000004000, left 0x0000000000004800

smsc911x 8000000.ethernet eth0: set_features() failed (-1); wanted
0x0000000000004000, left 0x0000000000004800

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 net-next] net/core: ensure features get disabled on new  lower devs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-17 10:10 +0100
  Re: [PATCH v2 net-next] net/core: ensure features get disabled on new  lower devs Geert Uytterhoeven <geert@linux-m68k.org> - 2015-11-17 11:10 +0100

csiph-web