Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro

From	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro
Date	2015-11-17 11:00 +0100
Message-ID	<qvLdo-3kN-23@gated-at.bofh.it> (permalink)
References	<qtwLw-7rg-3@gated-at.bofh.it> <qu6Fk-5dX-19@gated-at.bofh.it> <qv04N-6Qp-1@gated-at.bofh.it> <qvAUG-4Yp-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 16 November 2015 at 23:50, Laura Abbott <labbott@redhat.com> wrote:
> On 11/14/2015 11:38 PM, Ard Biesheuvel wrote:
>>
>> On 12 November 2015 at 21:21, Laura Abbott <labbott@fedoraproject.org>
>> wrote:
>>>
>>> The permissions in mark_rodata_ro trigger a build error
>>> with STRICT_MM_TYPECHECKS. Fix this by introducing
>>> PAGE_KERNEL_ROX for the same reasons as PAGE_KERNEL_RO.
>>
>>
>> Forgive the bikeshedding but perhaps PAGE_KERNEL_EXEC_RO is more
>> consistent?
>>
>
> powerpc was using PAGE_KERNEL_ROX so I went with that. Blame powerpc ;)
>

OK, in that case, let's keep PAGE_KERNEL_ROX

>>>
>>>  From Ard:
>>>
>>> "PAGE_KERNEL_EXEC has PTE_WRITE set as well, making the range
>>> writeable under the ARMv8.1 DBM feature, that manages the
>>> dirty bit in hardware (writing to a page with the PTE_RDONLY
>>> and PTE_WRITE bits both set will clear the PTE_RDONLY bit in that case)"
>>>
>>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org>
>>
>>
>> Acked-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>
>
> Thanks,
> Laura
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro Laura Abbott <labbott@redhat.com> - 2015-11-17 00:00 +0100
  Re: [PATCHv2] arm64: Fix R/O permissions in mark_rodata_ro Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2015-11-17 11:00 +0100

csiph-web