Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1270978

Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init

Show all headers | View raw

On Tuesday 17 November 2015 10:57:48 Krzysztof Kozlowski wrote:
> On 17.11.2015 07:17, Arnd Bergmann wrote:
> > On Monday 16 November 2015 23:36:42 Rafael J. Wysocki wrote:
> >>
> >> This should go in through the Samsung tree, so I'll leave it for them to pick
> >> it up (at least for the time being).
> > 
> > Ok, fair enough. Kukjin or Krzysztof, can you pick this up?
> 
> Sure.
> 
> As for the patch I think everything can be converted to init/initdata
> (as in attachment).
> 

I don't think so:

static struct subsys_interface s3c2442_plls169344_interface __initdata = {
        .name           = "s3c2442_plls169344",
        .subsys         = &s3c2442_subsys,
        .add_dev        = s3c2440_plls169344_add,
};

This gets passed into subsys_interface_register(), which is not __init
in turn. subsys_interface_register() then goes on to add
s3c2442_plls169344_interface into a linked list that is traversed
at runtime, but the __initdata section gets discarded so you now
have a broken list.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: do not mark s3c2410_plls_add as __init Arnd Bergmann <arnd@arndb.de> - 2015-11-16 22:30 +0100
  Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-11-16 23:10 +0100
    Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init Arnd Bergmann <arnd@arndb.de> - 2015-11-16 23:20 +0100
      Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-17 03:00 +0100
        Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init Arnd Bergmann <arnd@arndb.de> - 2015-11-17 10:10 +0100
          Re: [PATCH] cpufreq: do not mark s3c2410_plls_add as __init Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2015-11-18 01:50 +0100

csiph-web