Re: [PATCH 3/9] IB: add a helper to safely drain a QP

From	Sagi Grimberg <sagig@dev.mellanox.co.il>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/9] IB: add a helper to safely drain a QP
Date	2015-11-17 10:00 +0100
Message-ID	<qvKhk-2Hb-17@gated-at.bofh.it> (permalink)
References	(2 earlier) <qv1WW-81C-1@gated-at.bofh.it> <qvuYW-1eV-23@gated-at.bofh.it> <qvwR4-2pG-27@gated-at.bofh.it> <qvwR5-2pG-43@gated-at.bofh.it> <qvxk6-2PK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> That won't work for iWARP.  Is this code new?  I didn't see any errors that would result from this code when I tested iSER over
> cxgb4 with the old iwarp support patches.

It's there since ~3.17 I think...

>
> Perhaps we need another way to do this?  Like a completion object in the QP that gets triggered when the SQ and RQ become empty
> after a transition to ERROR (and CLOSING for iwarp).  Then a core service that just waits until the QP is empty.  Implementation of
> this design would hit the providers though since only they know when the flush is completed.

ULPs need a drain functionality, so ib_drain_qp() is the way to go...

How about we add a drain_qp() callout and have:

	if (qp->device->drain_qp) {
		qp->device->drain_qp();
		return;
	}

	IB drain qp logic...

This way iWARP devices can have their own magic on how to implement this
functionality.

Thoughts?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH 3/9] IB: add a helper to safely drain a QP Steve Wise <swise@opengridcomputing.com> - 2015-11-16 17:40 +0100
  RE: [PATCH 3/9] IB: add a helper to safely drain a QP "Steve Wise" <swise@opengridcomputing.com> - 2015-11-16 19:40 +0100
    Re: [PATCH 3/9] IB: add a helper to safely drain a QP Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-16 19:40 +0100
      RE: [PATCH 3/9] IB: add a helper to safely drain a QP "Steve Wise" <swise@opengridcomputing.com> - 2015-11-16 20:10 +0100
        Re: [PATCH 3/9] IB: add a helper to safely drain a QP Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-17 10:00 +0100
        Re: [PATCH 3/9] IB: add a helper to safely drain a QP Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-23 11:30 +0100
          Re: [PATCH 3/9] IB: add a helper to safely drain a QP Sagi Grimberg <sagig@dev.mellanox.co.il> - 2015-11-23 11:40 +0100
            Re: [PATCH 3/9] IB: add a helper to safely drain a QP 'Christoph Hellwig' <hch@lst.de> - 2015-11-23 15:40 +0100
            RE: [PATCH 3/9] IB: add a helper to safely drain a QP "Steve Wise" <swise@opengridcomputing.com> - 2015-11-23 15:50 +0100
          RE: [PATCH 3/9] IB: add a helper to safely drain a QP "Steve Wise" <swise@opengridcomputing.com> - 2015-11-23 15:50 +0100

csiph-web