Re: [PATCH] vhost: relax log address alignment

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] vhost: relax log address alignment
Date	2015-11-17 06:50 +0100
Message-ID	<qvHjr-QF-1@gated-at.bofh.it> (permalink)
References	<qvtzP-sT-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 11/16/2015 11:00 PM, Michael S. Tsirkin wrote:
> commit 5d9a07b0de512b77bf28d2401e5fe3351f00a240 ("vhost: relax used
> address alignment") fixed the alignment for the used virtual address,
> but not for the physical address used for logging.
>
> That's a mistake: alignment should clearly be the same for virtual and
> physical addresses,
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  drivers/vhost/vhost.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index eec2f11..080422f 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -819,7 +819,7 @@ long vhost_vring_ioctl(struct vhost_dev *d, int ioctl, void __user *argp)
>  		BUILD_BUG_ON(__alignof__ *vq->used > VRING_USED_ALIGN_SIZE);
>  		if ((a.avail_user_addr & (VRING_AVAIL_ALIGN_SIZE - 1)) ||
>  		    (a.used_user_addr & (VRING_USED_ALIGN_SIZE - 1)) ||
> -		    (a.log_guest_addr & (sizeof(u64) - 1))) {
> +		    (a.log_guest_addr & (VRING_USED_ALIGN_SIZE - 1))) {
>  			r = -EINVAL;
>  			break;
>  		}

Acked-by: Jason Wang <jasowang@redhat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] vhost: relax log address alignment "Michael S. Tsirkin" <mst@redhat.com> - 2015-11-16 16:10 +0100
  Re: [PATCH] vhost: relax log address alignment Jason Wang <jasowang@redhat.com> - 2015-11-17 06:50 +0100

csiph-web