RE: [PATCH] KVM: x86: always set accessed bit in shadow PTEs

From	"Zhang, Yang Z" <yang.z.zhang@intel.com>
Newsgroups	linux.kernel
Subject	RE: [PATCH] KVM: x86: always set accessed bit in shadow PTEs
Date	2015-11-17 02:00 +0100
Message-ID	<qvCMO-6dd-15@gated-at.bofh.it> (permalink)
References	<qukfg-5kp-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Paolo Bonzini wrote on 2015-11-13:
> Commit 7a1638ce4220 ("nEPT: Redefine EPT-specific link_shadow_page()",
> 2013-08-05) says:
> 
>     Since nEPT doesn't support A/D bit, we should not set those bit
>     when building the shadow page table.
> but this is not necessary.  Even though nEPT doesn't support A/D
> bits, and hence the vmcs12 EPT pointer will never enable them,
> we always use them for shadow page tables if available (see
> construct_eptp in vmx.c).  So we can set the A/D bits freely
> in the shadow page table.
> 
> This patch hence basically reverts commit 7a1638ce4220.
> 
> Cc: Yang Zhang <yang.z.zhang@Intel.com>
> Cc: Takuya Yoshikawa <yoshikawa_takuya_b1@lab.ntt.co.jp>
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

Looks good to me.

Best regards,
Yang


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

RE: [PATCH] KVM: x86: always set accessed bit in shadow PTEs "Zhang, Yang Z" <yang.z.zhang@intel.com> - 2015-11-17 02:00 +0100

csiph-web